Repository navigation
Conversation
No crate in this workspace depends on it. The copy that is used lives in alpenlabs/asm. The corepc-node workspace dep goes with it, since it had no other user here.
Contributor
|
Commit: ad4ac84 SP1 Execution Results
|
prajwolrg
marked this pull request as ready for review
October 12, 2026 07:01
prajwolrg
requested review from
alexhui01,
bewakes,
purusang,
storopoli and
voidash
as code owners
October 12, 2026 07:01
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
🔒 AI Security Review (claude-opus-5-5)✅ No security issues found. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2391 +/- ##
==========================================
+ Coverage 89.05% 89.15% +0.09%
==========================================
Files 443 434 -9
Lines 75766 75331 -435
==========================================
- Hits 67477 67163 -314
+ Misses 8289 8168 -121
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Member
|
@prajwolrg please rebase? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the local
strata-test-utils-btciocrate. Nothing in this workspace depends on it. The crate is maintained and used in alpenlabs/asm, and that copy stays inCargo.lockas a transitive dependency.The
corepc-nodeworkspace dependency is removed too, since this crate was its only user here. Thebitreqprofile override stays becausebitcoind-async-clientstill pulls inbitreq.Type of Change
Notes to Reviewers
Is this PR addressing any specification, design doc or external reference document?
Checklist
AI use: Claude Code found the references, made the removal, and wrote this description.
Related Issues
None.
🤖 Generated with Claude Code