Skip to content

chore: drop unused test-utils/data fixtures - #2392

Merged
storopoli merged 1 commit into
mainfrom
chore/drop-test-utils-data
Oct 12, 2026
Merged

storopoli merged 1 commit into
mainfrom
chore/drop-test-utils-data

Conversation

@prajwolrg

Copy link
Copy Markdown
Contributor

Description

Removes crates/test-utils/data/. It is not a crate, and nothing in this repo reads any file in it. The evm_ee witness fixtures are read only by alpen-ee tests, and alpen-ee keeps its own copy under crates/test-utils/data/evm_ee. The two mainnet block dumps (about 2 MB) and sp1_rollup_vk.json have no readers here, in alpen-ee, or in asm.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Found while dropping the unused strata-test-utils-btcio crate, which is in a separate PR.

Is this PR addressing any specification, design doc or external reference document?

  • Yes
  • No

If yes, please add relevant links:

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.
  • I have disclosed my use of AI in the body of this PR.

Related Issues

None.

AI assistance: this PR was prepared with Claude Code.

🤖 Generated with Claude Code

Nothing in this repo reads these files. The evm_ee witness fixtures moved
with the EE to alpen-ee, which keeps its own copy. The mainnet block dumps
and the SP1 rollup VK lost their last readers in earlier cleanups.
@prajwolrg
prajwolrg marked this pull request as ready for review October 12, 2026 07:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T07:24:38.668285Z 1a6e2d6 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-12T07:26:13.639340Z 1a6e2d6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

🔒 AI Security Review (claude-opus-5-5)

✅ No security issues found.

@bewakes bewakes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions

Copy link
Copy Markdown
Contributor

Commit: 1d3731b
Baseline: #2382 (65bec5b)
SP1 Execution Results

program cycles gas Δ cycles Δ gas
Checkpoint 2,782,155 3,212,830 0 (0.0%) 0 (0.0%)

@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.10%. Comparing base (65bec5b) to head (1a6e2d6).

@@            Coverage Diff             @@
##             main    #2392      +/-   ##
==========================================
- Coverage   89.10%   89.10%   -0.01%     
==========================================
  Files         441      441              
  Lines       75723    75723              
==========================================
- Hits        67475    67474       -1     
- Misses       8248     8249       +1     
Flag Coverage Δ
functional 58.77% <ø> (-0.07%) ⬇️
unit 81.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@storopoli storopoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1a6e2d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants