Skip to content

chore: use strata-ssz-tests from strata-common - #2393

Open
prajwolrg wants to merge 1 commit into
mainfrom
chore/use-strata-ssz-tests
Open

prajwolrg wants to merge 1 commit into
mainfrom
chore/use-strata-ssz-tests

Conversation

@prajwolrg

Copy link
Copy Markdown
Contributor

Description

Replaces the local strata-test-utils-ssz crate with strata-ssz-tests from strata-common and deletes the local copy. The ssz_proptest! macro is the same in both. strata-common ships it at the v0.4.0 tag we already pin, and asm already uses it, so this needs no version bump.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

alpen-ee depends on strata-test-utils-ssz from this repo at tag v0.4.0-rc.1. That keeps working. On its next alpen tag bump, alpen-ee will need the same swap: add strata-ssz-tests to its root Cargo.toml and update the imports in chain-types and acct-types.

Cargo.lock was edited by hand to swap only this one package. Letting cargo regenerate it also re-resolved some unrelated range dependencies (socket2, itertools, windows-sys). cargo metadata --locked accepts the edited file.

Is this PR addressing any specification, design doc or external reference document?

  • Yes
  • No

If yes, please add relevant links:

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.
  • I have disclosed my use of AI in the body of this PR.

Related Issues

None.

AI assistance: this PR was prepared with Claude Code.

🤖 Generated with Claude Code

strata-test-utils-ssz is a copy of strata-ssz-tests, which strata-common
already ships at the v0.4.0 tag we pin and which asm already uses. Keeping
two copies of the same macro lets them drift.

alpen-ee pulls strata-test-utils-ssz from this repo at v0.4.0-rc.1. It
keeps working on that tag but will need the same swap on its next bump.
@github-actions

Copy link
Copy Markdown
Contributor

Commit: 61641d1
Baseline: #2382 (65bec5b)
SP1 Execution Results

program cycles gas Δ cycles Δ gas
Checkpoint 2,782,155 3,212,830 0 (0.0%) 0 (0.0%)

@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.08%. Comparing base (65bec5b) to head (aec5489).
⚠️ Report is 4 commits behind head on main.

@@            Coverage Diff             @@
##             main    #2393      +/-   ##
==========================================
- Coverage   89.10%   89.08%   -0.03%     
==========================================
  Files         441      441              
  Lines       75723    75723              
==========================================
- Hits        67475    67458      -17     
- Misses       8248     8265      +17     
Flag Coverage Δ
functional 58.74% <ø> (-0.10%) ⬇️
unit 81.73% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crates/acct-types/src/messages.rs 88.68% <ø> (ø)
crates/acct-types/src/state.rs 90.47% <ø> (ø)
crates/ol/chain-types-v1/src/block.rs 94.66% <ø> (ø)
crates/ol/state-types-v1/src/account.rs 95.62% <ø> (ø)
crates/ol/state-types-v1/src/epochal.rs 100.00% <ø> (ø)
crates/ol/state-types-v1/src/global.rs 96.00% <ø> (ø)
crates/ol/state-types-v1/src/ledger.rs 99.57% <ø> (ø)
crates/ol/state-types-v1/src/snark_account.rs 95.83% <ø> (ø)
crates/ol/state-types-v1/src/toplevel.rs 94.63% <ø> (ø)
crates/ol/tx-types-v1/src/proofs.rs 100.00% <ø> (ø)
... and 2 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@storopoli storopoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨 blocking this until we have #2385 merged to see if any Cargo.lock changes breaks the VK. I don't want #2380 again.

@prajwolrg
prajwolrg marked this pull request as ready for review October 15, 2026 06:19
@prajwolrg
prajwolrg requested a review from storopoli October 15, 2026 06:19
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-15T06:19:57.381164Z aec5489 Draft marked ready
🔒 Security Review ⚠️ Failed 2026-10-15T06:19:58.053125Z aec5489 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

🔒 AI Security Review (claude-opus-5-5)

✅ No security issues found.

@storopoli

Copy link
Copy Markdown
Member

@prajwolrg rebase please

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants