Repository navigation
fix(deps): bump rustls-webpki, webpki-root-certs and rustls - #201
Merged
Merged
Conversation
rustls-webpki 0.103.16 rejects certificate paths through the distrusted emSign intermediates, whose private keys are now public (RUSTSEC-2026-0382). webpki-root-certs 1.0.10 fixes the same issue in its bundled root certificates (RUSTSEC-2026-0383). rustls 0.23.46 fixes RUSTSEC-2026-0346 through RUSTSEC-2026-0349. Those advisories have kept the cargo-audit job on main failing since Oct 19. All three crates come in through jsonrpsee in strata-rpc-tracing, so only Cargo.lock changes. The patched versions are inside the 14-day publish-age cooldown, so the update used the documented override.
🔒 AI Security Review (claude-opus-5-5)✅ No security issues found. |
storopoli
enabled auto-merge
October 21, 2026 15:14
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
storopoli
disabled auto-merge
October 22, 2026 17:38
Member
Author
|
Force-merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update three TLS crates in
Cargo.lockto fix open RustSec advisories:rustls-webpki0.103.15→0.103.16webpki-root-certs1.0.9→1.0.10rustls0.23.45→0.23.46RUSTSEC-2026-0382 and -0383 come from the same incident: the private keys of some distrusted emSign intermediates are now public, and the old versions can still accept certificate paths through them. The
rustlsadvisories are separate. They are why thecargo-auditjob onmainhas been failing since Oct 19.Type of Change
Notes to Reviewers
Only the three package versions and checksums in
Cargo.lockchange. No transitive dependencies were added or removed. All three crates come in throughjsonrpseeinstrata-rpc-tracing, so no manifest changes are needed. Downstream repos have to update their own lockfiles to pick up the fixes.The patched versions are less than 14 days old, so the update used the documented urgent cooldown override:
Validation used the pinned
nightly-2026-07-01toolchain:cargo audit(cargo-audit 0.22.2, current RustSec database) reports all six advisories onmainand no vulnerabilities with this lockfile. Both scans report the same four warnings foransi_term,bincode,paste, andscc.cargo clippy --examples --tests --benches --all-features --all-targets --lockedpassed.cargo nextest run --workspace --all-features --lockedpassed 674 of 674 tests.cargo test --doc --all-features --lockedpassed.cargo hack --each-feature(not installed locally;strata-rpc-tracinghas no features),cargo fmt, andtaplo, since no Rust or TOML sources changed.No new tests were added for these upstream dependency fixes. The before/after audit shows the vulnerable versions are gone.
Checklist
Related Issues
RUSTSEC-2026-0382, RUSTSEC-2026-0383, RUSTSEC-2026-0346, RUSTSEC-2026-0347, RUSTSEC-2026-0348, RUSTSEC-2026-0349
Same fix in alpen: alpenlabs/alpen#2410