Skip to content

♻️ Standardise mandatory AWS resource tagging across deployments#2283

Draft
jasonBirchall wants to merge 12 commits intomainfrom
improve-tagging
Draft

♻️ Standardise mandatory AWS resource tagging across deployments#2283
jasonBirchall wants to merge 12 commits intomainfrom
improve-tagging

Conversation

@jasonBirchall
Copy link
Collaborator

👀 Purpose

  • Implement the GDS mandatory AWS resource tagging strategy across all Terraform deployments
  • Ensure consistent cost allocation and resource management through standardised tags
  • Align documentation with actual implementation and provide a template for future deployments.

♻️ What's changed

  • Added complete AWS provider default_tags to opensearch and chat deployments (previously had no tagging).
  • Added missing mandatory System tag to govuk-publishing-infrastructure deployment
  • Added missing Environment tag to GitHub deployment
  • Standardised cluster-infrastructure and cluster-services to use local pattern for cleaner tag management
  • Updated terraform/docs/tagging-guide.md to reflect mandatory tags (Product, System, Environment, Owner)
  • Created terraform/docs/tagging-template.md with standardised tagging patterns for future deployments

📝 Notes

  • All 19 AWS deployments now have the 4 mandatory tags: Product, System, Environment, Owner
  • 3 deployments still need minor fixes: search-api-v2 (missing all tags), vpc (regional providers), cloudfront (global provider)
  • Template follows AWS provider default_tags best practice for automatic tag inheritance
  • No breaking changes - all new tags are additive and applied at the provider level

jasonBirchall added 3 commits June 11, 2025 16:32
- Add mandatory tags: Product, System, Environment, Owner
  - Update opensearch and chat deployments with complete tagging
  - Standardise cluster deployments to use locals pattern
  - Update documentation and add tagging template
It was a little unclear what the right value is here. We don't have a non-prod GitHub account, so it felt right to call it [GitHub] Production to specify context and severity.
@AgaDufrat
Copy link
Contributor

@jasonBirchall are you still working on this? Shall we convert it to Draft until you have time, so it doesn't pop up in our Seal notifications?

@jasonBirchall
Copy link
Collaborator Author

Hey, Aga. I’m still working on the final PRs to get this change in. I'm at the point where the TF plans look a little hairy now, so wish me luck. 😝

@jasonBirchall jasonBirchall marked this pull request as draft August 19, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants