♻️ Change the IAM role name for reports prototype#2387
Open
jasonBirchall wants to merge 1 commit intomainfrom
Open
♻️ Change the IAM role name for reports prototype#2387jasonBirchall wants to merge 1 commit intomainfrom
jasonBirchall wants to merge 1 commit intomainfrom
Conversation
Before this commit it is set to , which doesn't make a lot of sense. This change adds the word prototype and removes the second govuk instance
AP-Hunt
requested changes
Jul 4, 2025
|
|
||
| locals { | ||
| govuk_reports_service_account_name = "govuk-reports" | ||
| govuk_reports_service_account_name = "govuk-reports-prototype" |
Member
There was a problem hiding this comment.
This should probably still include the cluster id/name, otherwise we'll get conflicts if we try to deploy it in an ephemeral cluster (which share an AWS account)
Collaborator
Author
There was a problem hiding this comment.
so keep govuk-reports-govuk?
Collaborator
Author
There was a problem hiding this comment.
it's a good point on ephemeral clusters.
Collaborator
Author
There was a problem hiding this comment.
maybe remove the first govuk. Just so it doesn't make my skin crawl :p
Member
There was a problem hiding this comment.
It'll say govuk-reports-prototype-govuk in most envs, yeah. But in Terraform it'll read in a less skin itching way at least
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit it is set to
govuk-reports-govuk(the second govuk is the cluster name) , which doesn't make a lot of sense. This change adds the word prototype and removes the second govuk instance