Search API v2 add permission to delete storage objects#2988
Draft
Search API v2 add permission to delete storage objects#2988
Conversation
A scheduled task failed to upload Search API v2 evaluation results because a bucket object with the same name already existed, and the task lacked permission to delete it before replacing it. We would probably always want to replace an existing file anyway, so this commit grants the `storage.objects.delete` permission. Note that permissions are granted at the project level, whereas granting them at the resource level would better meet the principle of least privilege. We intend to refactor this when we remove the redundant infrastructure of manual evaluations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A scheduled task failed to upload Search API v2 evaluation results because a bucket object with the same name already existed, and the task lacked permission to delete it before replacing it.
We would probably always want to replace an existing file anyway, so this commit grants the
storage.objects.deletepermission.Note that permissions are granted at the project level, whereas granting them at the resource level would better meet the principle of least privilege. We intend to refactor this when we remove the redundant infrastructure of manual evaluations.