Skip to content

feat: Auto-learning custom dictionary suggestions (Review Queue) #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martin-forge wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: Auto-learning custom dictionary suggestions (Review Queue) #282

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
4979780
feat: Implement auto-learning custom dictionary suggestions via revie…
martin-forge Apr 14, 2026
8094b28
fix: Address review feedback — backup compat, trigger dedup, detectio…
martin-forge Apr 14, 2026
e052dcc
fix: Capture full-field baseline + guard LCS matrix size
martin-forge Apr 14, 2026
8fbfce5
fix: Finalize active session before restarting monitoring
martin-forge Apr 14, 2026
75398e1
refactor: Remove heuristic filtering from AutoLearn service
martin-forge Apr 14, 2026
f9d2501
feat: Implement tiered hybrid threshold for review queue
martin-forge Apr 14, 2026
a843444
fix: start monitoring only after text injection completes
martin-forge Apr 14, 2026
f411e19
fix: address codex P2 feedback regarding dictionary auto-learn edge c…
martin-forge Apr 14, 2026
f7f7ab4
Fix auto-learn handoff and approval conflicts
martin-forge Apr 14, 2026
58ced2e
Stop auto-learn immediately when disabled
martin-forge Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Sources/Fluid/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1916,6 +1916,9 @@ struct ContentView: View {
if typingTarget.shouldRestoreOriginalFocus {
await self.restoreFocusToRecordingTarget()
}
if let element = AutoLearnDictionaryService.shared.captureFocusedElement() {
AutoLearnDictionaryService.shared.prepareMonitoring(pastedText: finalText, element: element)
Comment thread
martin-forge marked this conversation as resolved.
Outdated
}
self.asr.typeTextToActiveField(
finalText,
preferredTargetPID: typingTarget.pid
Expand Down Expand Up @@ -1943,6 +1946,7 @@ struct ContentView: View {
aiModel: modelInfo.model,
aiProvider: modelInfo.provider
)
AutoLearnDictionaryService.shared.beginMonitoring()
Comment thread
martin-forge marked this conversation as resolved.
Outdated

NotchOverlayManager.shared.hide()
} else if shouldPersistOutputs,
Expand Down
226 changes: 226 additions & 0 deletions Sources/Fluid/Persistence/BackupService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,237 @@ struct SettingsBackupPayload: Codable, Equatable {
let pauseMediaDuringTranscription: Bool
let vocabularyBoostingEnabled: Bool
let customDictionaryEntries: [SettingsStore.CustomDictionaryEntry]
// Added in auto-learn dictionary PR — decode with defaults for older backups.
let autoLearnCustomDictionaryEnabled: Bool
let autoLearnCustomDictionarySuggestions: [SettingsStore.AutoLearnSuggestion]
Comment thread
martin-forge marked this conversation as resolved.
let selectedDictationPromptID: String?
let dictationPromptOff: Bool?
let selectedEditPromptID: String?
let defaultDictationPromptOverride: String?
let defaultEditPromptOverride: String?

private enum CodingKeys: String, CodingKey {
case selectedProviderID, selectedModelByProvider, savedProviders, modelReasoningConfigs
case selectedSpeechModel, selectedCohereLanguage
case hotkeyShortcut, promptModeHotkeyShortcut, promptModeShortcutEnabled
case promptModeSelectedPromptID, secondaryDictationPromptOff
case commandModeHotkeyShortcut, commandModeShortcutEnabled
case commandModeSelectedModel, commandModeSelectedProviderID
case commandModeConfirmBeforeExecute, commandModeLinkedToGlobal
case rewriteModeHotkeyShortcut, rewriteModeShortcutEnabled
case rewriteModeSelectedModel, rewriteModeSelectedProviderID, rewriteModeLinkedToGlobal
case cancelRecordingHotkeyShortcut
case showThinkingTokens, hideFromDockAndAppSwitcher
case accentColorOption, transcriptionStartSound
case transcriptionSoundVolume, transcriptionSoundIndependentVolume
case autoUpdateCheckEnabled, betaReleasesEnabled, enableDebugLogs, shareAnonymousAnalytics
case pressAndHoldMode, enableStreamingPreview, enableAIStreaming
case copyTranscriptionToClipboard, textInsertionMode
case preferredInputDeviceUID, preferredOutputDeviceUID
case visualizerNoiseThreshold, overlayPosition, overlayBottomOffset, overlaySize
case transcriptionPreviewCharLimit, userTypingWPM
case saveTranscriptionHistory, weekendsDontBreakStreak
case fillerWords, removeFillerWordsEnabled
case gaavModeEnabled, pauseMediaDuringTranscription
case vocabularyBoostingEnabled, customDictionaryEntries
case autoLearnCustomDictionaryEnabled, autoLearnCustomDictionarySuggestions
case selectedDictationPromptID, dictationPromptOff
case selectedEditPromptID
case defaultDictationPromptOverride, defaultEditPromptOverride
}

init(from decoder: Decoder) throws {
let container = try decoder.container(keyedBy: CodingKeys.self)
self.selectedProviderID = try container.decode(String.self, forKey: .selectedProviderID)
self.selectedModelByProvider = try container.decode([String: String].self, forKey: .selectedModelByProvider)
self.savedProviders = try container.decode([SettingsStore.SavedProvider].self, forKey: .savedProviders)
self.modelReasoningConfigs = try container.decode([String: SettingsStore.ModelReasoningConfig].self, forKey: .modelReasoningConfigs)
self.selectedSpeechModel = try container.decode(SettingsStore.SpeechModel.self, forKey: .selectedSpeechModel)
self.selectedCohereLanguage = try container.decode(SettingsStore.CohereLanguage.self, forKey: .selectedCohereLanguage)
self.hotkeyShortcut = try container.decode(HotkeyShortcut.self, forKey: .hotkeyShortcut)
self.promptModeHotkeyShortcut = try container.decode(HotkeyShortcut.self, forKey: .promptModeHotkeyShortcut)
self.promptModeShortcutEnabled = try container.decode(Bool.self, forKey: .promptModeShortcutEnabled)
self.promptModeSelectedPromptID = try container.decodeIfPresent(String.self, forKey: .promptModeSelectedPromptID)
self.secondaryDictationPromptOff = try container.decodeIfPresent(Bool.self, forKey: .secondaryDictationPromptOff)
self.commandModeHotkeyShortcut = try container.decode(HotkeyShortcut.self, forKey: .commandModeHotkeyShortcut)
self.commandModeShortcutEnabled = try container.decode(Bool.self, forKey: .commandModeShortcutEnabled)
self.commandModeSelectedModel = try container.decodeIfPresent(String.self, forKey: .commandModeSelectedModel)
self.commandModeSelectedProviderID = try container.decode(String.self, forKey: .commandModeSelectedProviderID)
self.commandModeConfirmBeforeExecute = try container.decode(Bool.self, forKey: .commandModeConfirmBeforeExecute)
self.commandModeLinkedToGlobal = try container.decode(Bool.self, forKey: .commandModeLinkedToGlobal)
self.rewriteModeHotkeyShortcut = try container.decode(HotkeyShortcut.self, forKey: .rewriteModeHotkeyShortcut)
self.rewriteModeShortcutEnabled = try container.decode(Bool.self, forKey: .rewriteModeShortcutEnabled)
self.rewriteModeSelectedModel = try container.decodeIfPresent(String.self, forKey: .rewriteModeSelectedModel)
self.rewriteModeSelectedProviderID = try container.decode(String.self, forKey: .rewriteModeSelectedProviderID)
self.rewriteModeLinkedToGlobal = try container.decode(Bool.self, forKey: .rewriteModeLinkedToGlobal)
self.cancelRecordingHotkeyShortcut = try container.decode(HotkeyShortcut.self, forKey: .cancelRecordingHotkeyShortcut)
self.showThinkingTokens = try container.decode(Bool.self, forKey: .showThinkingTokens)
self.hideFromDockAndAppSwitcher = try container.decode(Bool.self, forKey: .hideFromDockAndAppSwitcher)
self.accentColorOption = try container.decode(SettingsStore.AccentColorOption.self, forKey: .accentColorOption)
self.transcriptionStartSound = try container.decode(SettingsStore.TranscriptionStartSound.self, forKey: .transcriptionStartSound)
self.transcriptionSoundVolume = try container.decode(Float.self, forKey: .transcriptionSoundVolume)
self.transcriptionSoundIndependentVolume = try container.decode(Bool.self, forKey: .transcriptionSoundIndependentVolume)
self.autoUpdateCheckEnabled = try container.decode(Bool.self, forKey: .autoUpdateCheckEnabled)
self.betaReleasesEnabled = try container.decode(Bool.self, forKey: .betaReleasesEnabled)
self.enableDebugLogs = try container.decode(Bool.self, forKey: .enableDebugLogs)
self.shareAnonymousAnalytics = try container.decode(Bool.self, forKey: .shareAnonymousAnalytics)
self.pressAndHoldMode = try container.decode(Bool.self, forKey: .pressAndHoldMode)
self.enableStreamingPreview = try container.decode(Bool.self, forKey: .enableStreamingPreview)
self.enableAIStreaming = try container.decode(Bool.self, forKey: .enableAIStreaming)
self.copyTranscriptionToClipboard = try container.decode(Bool.self, forKey: .copyTranscriptionToClipboard)
self.textInsertionMode = try container.decode(SettingsStore.TextInsertionMode.self, forKey: .textInsertionMode)
self.preferredInputDeviceUID = try container.decodeIfPresent(String.self, forKey: .preferredInputDeviceUID)
self.preferredOutputDeviceUID = try container.decodeIfPresent(String.self, forKey: .preferredOutputDeviceUID)
self.visualizerNoiseThreshold = try container.decode(Double.self, forKey: .visualizerNoiseThreshold)
self.overlayPosition = try container.decode(SettingsStore.OverlayPosition.self, forKey: .overlayPosition)
self.overlayBottomOffset = try container.decode(Double.self, forKey: .overlayBottomOffset)
self.overlaySize = try container.decode(SettingsStore.OverlaySize.self, forKey: .overlaySize)
self.transcriptionPreviewCharLimit = try container.decode(Int.self, forKey: .transcriptionPreviewCharLimit)
self.userTypingWPM = try container.decode(Int.self, forKey: .userTypingWPM)
self.saveTranscriptionHistory = try container.decode(Bool.self, forKey: .saveTranscriptionHistory)
self.weekendsDontBreakStreak = try container.decode(Bool.self, forKey: .weekendsDontBreakStreak)
self.fillerWords = try container.decode([String].self, forKey: .fillerWords)
self.removeFillerWordsEnabled = try container.decode(Bool.self, forKey: .removeFillerWordsEnabled)
self.gaavModeEnabled = try container.decode(Bool.self, forKey: .gaavModeEnabled)
self.pauseMediaDuringTranscription = try container.decode(Bool.self, forKey: .pauseMediaDuringTranscription)
self.vocabularyBoostingEnabled = try container.decode(Bool.self, forKey: .vocabularyBoostingEnabled)
self.customDictionaryEntries = try container.decode([SettingsStore.CustomDictionaryEntry].self, forKey: .customDictionaryEntries)
// Backward-compatible defaults for keys added by auto-learn dictionary PR.
self.autoLearnCustomDictionaryEnabled = try container.decodeIfPresent(Bool.self, forKey: .autoLearnCustomDictionaryEnabled) ?? false
self.autoLearnCustomDictionarySuggestions = try container.decodeIfPresent([SettingsStore.AutoLearnSuggestion].self, forKey: .autoLearnCustomDictionarySuggestions) ?? []
self.selectedDictationPromptID = try container.decodeIfPresent(String.self, forKey: .selectedDictationPromptID)
self.dictationPromptOff = try container.decodeIfPresent(Bool.self, forKey: .dictationPromptOff)
self.selectedEditPromptID = try container.decodeIfPresent(String.self, forKey: .selectedEditPromptID)
self.defaultDictationPromptOverride = try container.decodeIfPresent(String.self, forKey: .defaultDictationPromptOverride)
self.defaultEditPromptOverride = try container.decodeIfPresent(String.self, forKey: .defaultEditPromptOverride)
}

// Memberwise init for programmatic construction (backup export).
init(
selectedProviderID: String,
selectedModelByProvider: [String: String],
savedProviders: [SettingsStore.SavedProvider],
modelReasoningConfigs: [String: SettingsStore.ModelReasoningConfig],
selectedSpeechModel: SettingsStore.SpeechModel,
selectedCohereLanguage: SettingsStore.CohereLanguage,
hotkeyShortcut: HotkeyShortcut,
promptModeHotkeyShortcut: HotkeyShortcut,
promptModeShortcutEnabled: Bool,
promptModeSelectedPromptID: String?,
secondaryDictationPromptOff: Bool?,
commandModeHotkeyShortcut: HotkeyShortcut,
commandModeShortcutEnabled: Bool,
commandModeSelectedModel: String?,
commandModeSelectedProviderID: String,
commandModeConfirmBeforeExecute: Bool,
commandModeLinkedToGlobal: Bool,
rewriteModeHotkeyShortcut: HotkeyShortcut,
rewriteModeShortcutEnabled: Bool,
rewriteModeSelectedModel: String?,
rewriteModeSelectedProviderID: String,
rewriteModeLinkedToGlobal: Bool,
cancelRecordingHotkeyShortcut: HotkeyShortcut,
showThinkingTokens: Bool,
hideFromDockAndAppSwitcher: Bool,
accentColorOption: SettingsStore.AccentColorOption,
transcriptionStartSound: SettingsStore.TranscriptionStartSound,
transcriptionSoundVolume: Float,
transcriptionSoundIndependentVolume: Bool,
autoUpdateCheckEnabled: Bool,
betaReleasesEnabled: Bool,
enableDebugLogs: Bool,
shareAnonymousAnalytics: Bool,
pressAndHoldMode: Bool,
enableStreamingPreview: Bool,
enableAIStreaming: Bool,
copyTranscriptionToClipboard: Bool,
textInsertionMode: SettingsStore.TextInsertionMode,
preferredInputDeviceUID: String?,
preferredOutputDeviceUID: String?,
visualizerNoiseThreshold: Double,
overlayPosition: SettingsStore.OverlayPosition,
overlayBottomOffset: Double,
overlaySize: SettingsStore.OverlaySize,
transcriptionPreviewCharLimit: Int,
userTypingWPM: Int,
saveTranscriptionHistory: Bool,
weekendsDontBreakStreak: Bool,
fillerWords: [String],
removeFillerWordsEnabled: Bool,
gaavModeEnabled: Bool,
pauseMediaDuringTranscription: Bool,
vocabularyBoostingEnabled: Bool,
customDictionaryEntries: [SettingsStore.CustomDictionaryEntry],
autoLearnCustomDictionaryEnabled: Bool = false,
autoLearnCustomDictionarySuggestions: [SettingsStore.AutoLearnSuggestion] = [],
selectedDictationPromptID: String?,
dictationPromptOff: Bool?,
selectedEditPromptID: String?,
defaultDictationPromptOverride: String?,
defaultEditPromptOverride: String?
) {
self.selectedProviderID = selectedProviderID
self.selectedModelByProvider = selectedModelByProvider
self.savedProviders = savedProviders
self.modelReasoningConfigs = modelReasoningConfigs
self.selectedSpeechModel = selectedSpeechModel
self.selectedCohereLanguage = selectedCohereLanguage
self.hotkeyShortcut = hotkeyShortcut
self.promptModeHotkeyShortcut = promptModeHotkeyShortcut
self.promptModeShortcutEnabled = promptModeShortcutEnabled
self.promptModeSelectedPromptID = promptModeSelectedPromptID
self.secondaryDictationPromptOff = secondaryDictationPromptOff
self.commandModeHotkeyShortcut = commandModeHotkeyShortcut
self.commandModeShortcutEnabled = commandModeShortcutEnabled
self.commandModeSelectedModel = commandModeSelectedModel
self.commandModeSelectedProviderID = commandModeSelectedProviderID
self.commandModeConfirmBeforeExecute = commandModeConfirmBeforeExecute
self.commandModeLinkedToGlobal = commandModeLinkedToGlobal
self.rewriteModeHotkeyShortcut = rewriteModeHotkeyShortcut
self.rewriteModeShortcutEnabled = rewriteModeShortcutEnabled
self.rewriteModeSelectedModel = rewriteModeSelectedModel
self.rewriteModeSelectedProviderID = rewriteModeSelectedProviderID
self.rewriteModeLinkedToGlobal = rewriteModeLinkedToGlobal
self.cancelRecordingHotkeyShortcut = cancelRecordingHotkeyShortcut
self.showThinkingTokens = showThinkingTokens
self.hideFromDockAndAppSwitcher = hideFromDockAndAppSwitcher
self.accentColorOption = accentColorOption
self.transcriptionStartSound = transcriptionStartSound
self.transcriptionSoundVolume = transcriptionSoundVolume
self.transcriptionSoundIndependentVolume = transcriptionSoundIndependentVolume
self.autoUpdateCheckEnabled = autoUpdateCheckEnabled
self.betaReleasesEnabled = betaReleasesEnabled
self.enableDebugLogs = enableDebugLogs
self.shareAnonymousAnalytics = shareAnonymousAnalytics
self.pressAndHoldMode = pressAndHoldMode
self.enableStreamingPreview = enableStreamingPreview
self.enableAIStreaming = enableAIStreaming
self.copyTranscriptionToClipboard = copyTranscriptionToClipboard
self.textInsertionMode = textInsertionMode
self.preferredInputDeviceUID = preferredInputDeviceUID
self.preferredOutputDeviceUID = preferredOutputDeviceUID
self.visualizerNoiseThreshold = visualizerNoiseThreshold
self.overlayPosition = overlayPosition
self.overlayBottomOffset = overlayBottomOffset
self.overlaySize = overlaySize
self.transcriptionPreviewCharLimit = transcriptionPreviewCharLimit
self.userTypingWPM = userTypingWPM
self.saveTranscriptionHistory = saveTranscriptionHistory
self.weekendsDontBreakStreak = weekendsDontBreakStreak
self.fillerWords = fillerWords
self.removeFillerWordsEnabled = removeFillerWordsEnabled
self.gaavModeEnabled = gaavModeEnabled
self.pauseMediaDuringTranscription = pauseMediaDuringTranscription
self.vocabularyBoostingEnabled = vocabularyBoostingEnabled
self.customDictionaryEntries = customDictionaryEntries
self.autoLearnCustomDictionaryEnabled = autoLearnCustomDictionaryEnabled
self.autoLearnCustomDictionarySuggestions = autoLearnCustomDictionarySuggestions
self.selectedDictationPromptID = selectedDictationPromptID
self.dictationPromptOff = dictationPromptOff
self.selectedEditPromptID = selectedEditPromptID
self.defaultDictationPromptOverride = defaultDictationPromptOverride
self.defaultEditPromptOverride = defaultEditPromptOverride
}
}

struct AppBackupDocument: Codable, Equatable {
Expand Down
Loading