fix: add nil checks to BinarySource methods#1
Merged
qj0r9j0vc2 merged 1 commit intomainfrom Jan 20, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BinarySourcemethods to prevent SIGSEGV panicIsLocal(),IsGitHubRelease(),IsValid()returnfalsewhen nilMarkValid(),MarkInvalid()are no-ops when nilValidate()returns descriptive error when nilProblem
The upgrade command panics with nil pointer dereference at
binary_source.go:149whenBinarySourceis nil:Root Cause
At
upgrade.go:294,selection.BinarySource.IsLocal()is called without nil check. The interactive selection can return nilBinarySourcein certain flows.Test plan
TestBinarySourceNilSafetyverifying all methods handle nil safelygo build ./...passesgo test ./internal/domain/...passes