addToLibraryHeaderSearchPaths - handle non-inherited single values #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabbou
changed the title
|
Any chance you can take a look on it soon, @alunny? 🙏 |
Collaborator
|
@grabbou any chance you could add a test for single values please ? |
Author
|
Will do later today. BTW, isn't that already covered by all values |
Collaborator
|
@grabbou is there a test for |
Closed
Author
|
Nope since we don't use it anywhere in that method (the error was coming from our code). Now that we convert all string values to an array (not just inherited) https://github.com/alunny/node-xcode/pull/96/files#diff-35bc421794193e73d972308b4f2f3598R1175 it's not going to happen :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94. Locally all tests are green, meaning that the change is at least backwards compatible. Not sure if we need any extra test-case for that as the conversion to an array already happens for all
$(inherited)values, which is covered.