feat: Remove SteamVR driver registration modes #2755
Conversation
alvr/dashboard/src/main.rs
Outdated
| // Kill any other dashboard instance | ||
| let self_path = std::env::current_exe().unwrap(); | ||
| for proc in sysinfo::System::new_all().processes_by_name(OsStr::new(&afs::dashboard_fname())) { | ||
| if let Some(other_path) = proc.exe() { | ||
| if other_path == self_path { | ||
| proc.kill(); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I get the rough intent, but what exactly would the conflict be, as long as both aren't starting an instance of steamvr?
There was a problem hiding this comment.
This is helpful for a check I added on the driver side, to cancel driver startup if the driver instance does not correspond to the current opened dashboard. This is because by not unregistering the ALVR driver, multiple ALVR drivers might attempt loading. And we still want to support the use case of switching between multiple ALVR versions.
Since only one driver is allowed to start at any given moment, then we should also force to have only one dashboard
There was a problem hiding this comment.
I guess it's fine, I think we should probably output a warning when doing that so it's less confusing
|
Also fix the failing checks, ideally using the path shortcut thingy from the adb pr |
zmerp
force-pushed
the
remove-driver-reg-opts
branch
2 times, most recently
from
a3392f3 to
a1a42a0
Compare
zmerp
force-pushed
the
remove-driver-reg-opts
branch
from
a1a42a0 to
faf414b
Compare
zmerp
force-pushed
the
remove-driver-reg-opts
branch
4 times, most recently
from
9e9226e to
9102c12
Compare
zmerp
force-pushed
the
remove-driver-reg-opts
branch
from
9102c12 to
42289f9
Compare
At SteamVR launch, unconditionally register the ALVR driver. Also remove driver list backup.
In this PR I implement some sanity checks, that are now necessary since there is no unregistration of the driver:
This should be sufficient to handle multiple ALVR installations (Steam release or not).
This PR should be merged only after #2754 and #2757