More efficient data structures #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialize into a string not json Store items in a Uint8Array Send out chunks over multiple event loop ticks Change Chunk size to 16 instead of 32 to cut down on cost of re-rendering and transmitting chunks on block place.
killerrin
approved these changes
Feb 20, 2019
| for (let x = -2; x < 2; x += 1) { | ||
| for (let z = -2; z < 2; z += 1) { | ||
| for (let x = -4; x < 4; x += 1) { | ||
| for (let z = -4; z < 4; z += 1) { |
There was a problem hiding this comment.
This seems like something you have been managing and changing these variables a lot. Every time what we mess with the Chunk Size in the config. Maybe it would be a good idea to move it into a variable in the CONFIG?
p7g
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize into a string not json
Store items in a Uint8Array
Send out chunks over multiple event loop ticks
Change Chunk size to 16 instead of 32 to cut down on cost of
re-rendering and transmitting chunks on block place.