Fix clickhouse schema dump with non-default database #676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of using a generated
schema.sqlwith ClickHouse in Docker.The ClickHouse entrypoint runs every
.sqlfile in/docker-entrypoint-initdb.dduring server startup, but it executes them against the default database.It works if the schema dump was created from the default database, but it fails otherwise:
This fix prefixes
migrations_table_namewithdb_name.in the generated schema, making it consistent with the table creation statements and with other drivers.Note
Ensures ClickHouse schema dumps are fully qualified with the database name and consistently quoted.
quotedDatabaseName()inCreateDatabaseand schema generation; add helper for quoting the current databaseschemaDumpto derive the database name internally (remove param)db.tableinschemaMigrationsDumpWritten by Cursor Bugbot for commit 9bdd3f9. This will update automatically on new commits. Configure here.