Remove unnecessary NODE_AUTH_TOKEN line #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
amacneil
force-pushed
the
adrian/npm-publish-2
branch
from
9ed8d73 to
9f226dc
Compare
.github/workflows/ci.yml
Outdated
|
|
||
| - run: npm run publish | ||
| if: ${{ startsWith(github.ref, 'refs/tags/v') }} | ||
| # if: ${{ startsWith(github.ref, 'refs/tags/v') }} |
There was a problem hiding this comment.
Publish condition commented out runs on all builds
Medium Severity
The if: ${{ startsWith(github.ref, 'refs/tags/v') }} condition has been commented out, causing the npm publish step to run on every CI build instead of only on tagged releases. This appears to be debugging code used to test the NODE_AUTH_TOKEN change. Combined with the --dry-run flag it's currently harmless, but if that flag is removed, this would cause unintended publish attempts on every commit.
amacneil
force-pushed
the
adrian/npm-publish-2
branch
from
9f226dc to
9f3287e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line was not actually necessary. I didn't notice that it worked fine without.
Turns out upgrading NPM was the main required step to get this working.
Note
Adjusts release pipeline and TypeScript publish behavior, plus a patch version bump.
typescript/publish.ts: removeNODE_AUTH_TOKENunsetting andnpm --versioncheck; add--dry-runtonpm publish.github/workflows/ci.yml: comment out the tag-only condition for the NPM publish steppkg/dbmate/version.go: bumpVersionto2.29.2Written by Cursor Bugbot for commit 9f226dc. This will update automatically on new commits. Configure here.