Skip to content

Conversation

@dossy
Copy link
Collaborator

@dossy dossy commented Jan 15, 2026

Note

Adds version-aware dump behavior and testability to MySQL driver.

  • Introduces getMysqldumpVersion to parse dump client output, determine mysql vs mariadb, version, and select mysqldump or mariadb-dump
  • Changes mysqldumpArgs to accept version info and switch to --ssl-mode=* for MySQL ≥ 8 while retaining legacy flags otherwise; preserves existing host/port/socket/user/pass handling
  • Updates DumpSchema to invoke the detected dump command with version-appropriate args
  • Adds exec command/lookpath indirection for tests and comprehensive unit tests for version detection and args across MySQL/MariaDB variants

Written by Cursor Bugbot for commit da6e82b. This will update automatically on new commits. Configure here.

@dossy dossy linked an issue Jan 15, 2026 that may be closed by this pull request
@dossy dossy added the go Pull requests that update Go code label Jan 15, 2026
@dossy dossy merged commit ac08b99 into amacneil:main Jan 15, 2026
11 checks passed
@dossy dossy deleted the version-aware-mysqldump branch January 15, 2026 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: mysqldump: [ERROR] unknown variable 'ssl=false'. mysql 8.0

2 participants