fix: Correctly parse date skeleton EEEE to a long weekday like "Tuesday" (upgrades to intl-messageformat@10 internally)
#1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amannn
changed the title
amannn
changed the title
amannn
changed the title
EEEE to a long weekday like "Tuesday" (upgrades to intl-messageformat@10 internally)
amannn
changed the title
EEEE to a long weekday like "Tuesday" (upgrades to intl-messageformat@10 internally)EEEE to a long weekday like "Tuesday" (upgrades to intl-messageformat@10 internally)
juanforlizzi
pushed a commit
to juanforlizzi/next-intl
that referenced
this pull request
Jan 16, 2025
…sday" (upgrades to `intl-messageformat@10` internally) (amannn#1039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clarifies docs on which skeleton patterns can be used.
This increases the bundle size slightly, but being locked from upgrading the message parser isn't an option either (some dependencies like the skeleton parser were pinned by the message parser). Ultimately, we'll get rid of the ICU parser on the client side anyway: #705.