fix: Extractor description logic fix #2203
Closed
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when a message ID appeared in multiple files with different descriptions, the description from the last processed file would overwrite earlier ones. This change updates the merging logic to preserve the existing description if present, ensuring that the first description encountered (e.g. from the first file processed) is used. This aligns with the requirement "first description wins". The test case expectation is updated to match "Description from FileY" (FileY processed first).
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amannn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects message description merging logic to ensure "first description wins" behavior.
The previous merging logic for message descriptions would overwrite an existing description if a later-processed file also had one, violating the intended "first description wins" rule. This change ensures that if a description already exists from a previously processed file, it is preserved.