Improved: code for handling edge cases (hotwax#293)

amansinghbais · Aug 6, 2024 · a21dca7 · a21dca7
1 parent 21f083e
commit a21dca7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/src/services/UserService.ts b/src/services/UserService.ts
@@ -36,7 +36,7 @@ const moquiLogin = async (omsRedirectionUrl: string, token: string): Promise <an
       throw "Sorry, login failed. Please try again";
     }
   } catch(err) {
-    return Promise.resolve("Sorry, login failed. Please try again");
+    return Promise.resolve("");
   }
   return Promise.resolve(api_key)
 }

diff --git a/src/store/modules/user/actions.ts b/src/store/modules/user/actions.ts
@@ -70,6 +70,8 @@ const actions: ActionTree<UserState, RootState> = {
             const api_key = await UserService.moquiLogin(omsRedirectionUrl, token)
             if(api_key) {
               dispatch("setOmsRedirectionInfo", { url: omsRedirectionUrl, token: api_key })
+            } else {
+              showToast(translate("Some functionality of this app might not work properly, Since moqui is not setup for this account."))
             }
           } else {
             showToast(translate("Some functionality of this app might not work properly, Since moqui is not setup for this account."))

diff --git a/src/views/product-details.vue b/src/views/product-details.vue
@@ -453,7 +453,7 @@ export default defineComponent({
               'Content-Type': 'multipart/form-data;'
           },
           data: formData
-      }).then(async () => {
+      }).then(() => {
         this.store.dispatch("order/removeItems", { items: selectedItems });
         UserService.runNow();
       }).finally(() => emitter.emit("dismissLoader"))