Skip to content
This repository was archived by the owner on Feb 24, 2018. It is now read-only.

Adding lib folder. #652

Merged
merged 2 commits into from
Jan 12, 2018
Merged

Adding lib folder. #652

merged 2 commits into from
Jan 12, 2018

Conversation

itrestian
Copy link
Contributor

No description provided.

@itrestian itrestian merged commit a6b96bf into master Jan 12, 2018
@jogold
Copy link
Contributor

jogold commented Jan 12, 2018

Hi @itrestian, i don't understand why you are adding the lib folder to the repo. It's a build of src and should not be tracked, only included when publishing to npm. Otherwise it makes things complicated when making changes to the repo in the src folder.

@itrestian
Copy link
Contributor Author

Yes but basically the main entry point in the package.json points to the lib folder and it makes things confusing for people that don't have it generated cause they require the library and it doesn't work.

@jogold
Copy link
Contributor

jogold commented Jan 12, 2018

People do not need to generate it, you have to build it and include it when publishing to npm, so when people require the library it will be there.

All npm repos work this way...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants