feature: updates to error mitigation examples#814
feature: updates to error mitigation examples#814sesmart merged 77 commits intoamazon-braket:feature/err_mitfrom
Conversation
|
Overall I think the license-handling solution is good. The rest is how to consistently practice this. As a step to inform developers, we could add
|
| "S603", # `subprocess` call: check for execution of untrusted input | ||
| ] | ||
|
|
||
| [tool.hatch.envs.test-mitiq] |
There was a problem hiding this comment.
This could just be a mitiq env. Also moving the pip install -r extra/requirements-mitiq.txt as a post-install-command may be cleaner if someone wants to access the env
There was a problem hiding this comment.
After discussion, maintain testing for mitiq as it is solely for testing. But expanded test to incorporate requirements extra with requirements, and also updated dependabot.
examples/error_mitigation/on_mitiq/0_Getting_started_with_mitiq_on_Braket.ipynb
Show resolved
Hide resolved
examples/error_mitigation/on_mitiq/0_Getting_started_with_mitiq_on_Braket.ipynb
Show resolved
Hide resolved
examples/error_mitigation/on_mitiq/1_Readout_mitigation_with_mitiq.ipynb
Show resolved
Hide resolved
examples/error_mitigation/on_mitiq/2_Zero_noise_extrapolation_with_mitiq.ipynb
Show resolved
Hide resolved
natestemen
left a comment
natestemen
left a comment
There was a problem hiding this comment.
Hope you don't mind me jumping in here, but I saw a few things I wanted to note. Overall I think this set of notebooks are really amazing and will do a lot to help people use QEM on braket (and hopefully using mitiq too 😏).
examples/error_mitigation/on_mitiq/0_Getting_started_with_mitiq_on_Braket.ipynb
Outdated
Show resolved
Hide resolved
examples/error_mitigation/on_mitiq/0_Getting_started_with_mitiq_on_Braket.ipynb
Outdated
Show resolved
Hide resolved
examples/error_mitigation/on_mitiq/0_Getting_started_with_mitiq_on_Braket.ipynb
Outdated
Show resolved
Hide resolved
examples/error_mitigation/on_mitiq/0_Getting_started_with_mitiq_on_Braket.ipynb
Outdated
Show resolved
Hide resolved
examples/error_mitigation/on_mitiq/0_Getting_started_with_mitiq_on_Braket.ipynb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Is there a next notebook? I thought this was the last.
There was a problem hiding this comment.
Clarified this - there is another one in the supplemental area, that implements a pipeline on Ankaa-3.
examples/error_mitigation/on_mitiq/4_Error_mitigation_workflow_with_mitiq.ipynb
Show resolved
Hide resolved
There was a problem hiding this comment.
Actually found 4! :) Thanks for catching this.
examples/error_mitigation/on_mitiq/4_Error_mitigation_workflow_with_mitiq.ipynb
Show resolved
Hide resolved
There was a problem hiding this comment.
I've struggled with this same "wrap up" before while writing tutorials for mitiq since it's not always the case that individual techniques provide and improvement or the combination is necessarily the best on a simple noise model. I do think it's worth making a note about it here, though. Maybe what you say below is enough.
There was a problem hiding this comment.
The results here were actually wrong it turns out 😭 - missing the proper REM correction, which now should be fixed. Added some text here as well.
…q_on_Braket.ipynb Co-authored-by: nate stemen <nate@stemen.email>
…q_on_Braket.ipynb Co-authored-by: nate stemen <nate@stemen.email>
…q_on_Braket.ipynb Co-authored-by: nate stemen <nate@stemen.email>
…q_on_Braket.ipynb Co-authored-by: nate stemen <nate@stemen.email>
…_with_mitiq.ipynb Co-authored-by: nate stemen <nate@stemen.email>
…q_on_Braket.ipynb Co-authored-by: nate stemen <nate@stemen.email>
…_with_mitiq.ipynb Co-authored-by: nate stemen <nate@stemen.email>
Co-authored-by: nate stemen <nate@stemen.email>
4 participants
Issue #, if available:
Description of changes:
Added new error mitigation examples.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.