Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-order routes correctly #110

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Conversation

kennedymwavu
Copy link
Contributor

closes #109

  1. correctly re-order routes by checking the length of the route path itself, and not the pattern.

  2. remove redundant chunks in reorder_routes(), specifically:

    new_routes <- as.list(c(seq_len(nrow(df))))
    for(i in seq_len(nrow(df))) {
      new_routes[[i]] <- private$.routes[[df$order[i]]]
    }

    which is identical to private$.routes[df$order] since [ is vectorized.

  3. fix failing test on Request by expecting error when non-existent methods are called.

@kennedymwavu kennedymwavu linked an issue Feb 25, 2025 that may be closed by this pull request
@JohnCoene
Copy link
Collaborator

Awesome, thanks!

@JohnCoene JohnCoene merged commit 828f153 into master Feb 25, 2025
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-order routes correctly
2 participants