Feat/cor 32 requests made through client never error #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeT-Amplience
requested review from
pixelscript,
dev-warner,
Chattox and
nataly-itomy
dev-warner
reviewed
Jan 25, 2022
| @@ -88,4 +89,20 @@ export class HttpClient { | |||
| return this.DEFAULT_ERROR; | |||
| } | |||
| } | |||
|
|
|||
| public async fetch(config: HttpRequest): Promise<HttpResponse> { | |||
There was a problem hiding this comment.
perfect, would be good to get some basic docs down as well.
also DEFAULT_ERROR shows the shape of errors we normally return from API errors. unsure if we need to follow that shape here but looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds wrapper method to
request()throwing an error when requests fail.