Skip to content

refactor: optimize get links #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: optimize get links #581

wants to merge 1 commit into from

Conversation

@Connormiha
Copy link

@Connormiha Connormiha commented Sep 12, 2023

Summary

Minor optimization: I have simply replaced getElementsByTagName + Array.from with querySelectorAll, which already has a forEach method.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinpagtakhan kevinpagtakhan kevinpagtakhan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Connormiha @kevinpagtakhan