Skip to content

feat: Web experiment page objects #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 89 commits into
base: main
Choose a base branch
from
Open

feat: Web experiment page objects #165

wants to merge 89 commits into from

Conversation

tyiuhc
Copy link
Collaborator

@tyiuhc tyiuhc commented Mar 18, 2025 •
edited
Loading

Summary

Add page view object and scoped mutation support for web experiments

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: No

tyiuhc and others added 30 commits November 5, 2024 11:51
@tyiuhc
update doFlags to take user object, update tag script to fetch remote…
34c2cb6 
… flags
@tyiuhc
fix applyVariants logic
a463740
@tyiuhc
create remote flag fetch test and clean up exisiting tests
348d857
@tyiuhc
refactor unit tests code
936f27a
@tyiuhc
add unit tests
27b71cd
@tyiuhc
update unit tests, update getFlags with deliveryMethod arg
987031e
@tyiuhc
fix lint
f729fe4
@tyiuhc
fix tests
a93d63a
@tyiuhc
fix doFlags
6a91800
@tyiuhc
fix web remote eval preview unit test
d8a5109
@tyiuhc
remove unused util
c40f7ed
@tyiuhc
remove unused import
7db6dd4
@tyiuhc
fix doFlags user creation
2285a9d
@tyiuhc
fix web_exp_id generation for backwards compatability
eea5ef4
@tyiuhc
nit: formatting
a379647
@tyiuhc
refactor parsing initial flags, add antiflicker for remote blocking f…
a2ad01e 
…lags
@tyiuhc
update getflags options, exclude x-amp-exp-user header when no user/d…
bfce7c6 
…evice id, make doFlags private
@tyiuhc
Merge branch 'main' into web-remote-eval
1a72974
@tyiuhc
fix: test
ac60b53
@tyiuhc
refactor and add comment for setting IDs
e8b064f
@tyiuhc
make all remote flags locally evaluable, only applyVariants present i…
c8bd924 
…n initialFlags
@tyiuhc
feat: modularized WebExperiment class
b83f131
@tyiuhc
update tests
4ffb6fa
@tyiuhc
Add additional methods
ba6e8b8
@tyiuhc
Refactor and add additional methods
718f02a
@tyiuhc
Additional tests and config
73cd67f
@tyiuhc
update tests
99ad580
@tyiuhc
update with index
4cdabc7
@tyiuhc
add server zone config
b46f8bd
@tyiuhc
merge main
6e8e25b
@tyiuhc tyiuhc force-pushed the web-page-trigger branch from b8a4cc9 to 3766de3 Compare March 19, 2025 23:40
@tyiuhc tyiuhc marked this pull request as ready for review March 19, 2025 23:44
@tyiuhc tyiuhc requested a review from bgiori March 21, 2025 15:47
tyiuhc and others added 22 commits March 21, 2025 10:40
@tyiuhc
add backwards compatibility with page targeting segments, remove loda…
6160792 
…sh dependency
@tyiuhc
update yarn.lock
a5fab43
@tyiuhc
clean up comments
f33ff41
@tyiuhc
update scope checking logic
6e60ace
@tyiuhc
use SubscriptionManager class
026075a
@tyiuhc
fix lint
5b4af50
@tyiuhc
fix tests
d75898d
@tyiuhc
update visual editor mode handling
a080efd
@tyiuhc
Merge branch 'main' into web-page-trigger
718a90b
@tyiuhc
update PageObject type, add subscriber API
fab16b2
@tyiuhc
update with subscribe API
fc7c988
@tyiuhc
update with setPageObjects
83e5a15
@tyiuhc
update activePages upon setPageObjects
540fb92
@tyiuhc
clear activePages upon setPageObjects
88e9197
@tyiuhc
fix lint
fc6c40d
@tyiuhc
update to use PageObjects id
465b275
@tyiuhc
update to use PageObjects type
9d2e7f0
@tyiuhc
revert inactive injects
fb492d1
@tyiuhc
revert all injected code upon page nav
6b0f3ab
@tyiuhc
fix revert variants
6a4e9ef
@tyiuhc
fix test.yml
c6dcb52
@tyiuhc
fix: should not do redirect upon landing on redirected page
f10e44c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgiori bgiori Awaiting requested review from bgiori

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tyiuhc