Selected lines in Download/Shared lists become illegible when losing focus #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In several lists across amule, a selected line that loses focus becomes illegible because it is drawn with a white text on a white background.
There are a couple of ways to reproduce it: It happens when right-clicking on a line in the list. It also happens when selecting a line in the downloads/shared list (upper side of the window), and then clicking a line in the secondary list about clients (bottom side of the window).
The affected windows are: Downloads and Shared.
The Search window is not affected by this issue.
When comparing them, all of them use the same colour scheme, but the affected classes are using a Blend() on the colours, while the unaffected class isn't. The proposed change is to remove the Blend() on the colours from the affected classes.
Attaching a couple of screenshots before and after the fix.
The test environment has been Ubuntu 24.04, compiling the last version from master with wxWidgets 3.2.4 and boost 1.83.
Before: the third line is selected in the upper list, but when clicking on a peer in the bottom list, the line becomes illegible:
After: a line is selected in the upper list, and when clicking on a peer in the bottom list, the line can still be read: