Skip to content

Commit

Permalink
fix php vendor-order-api boolean default value and remove DataKiosk s… (
Browse files Browse the repository at this point in the history
#108)

* fix php vendor-order-api boolean default value and remove DataKiosk skip test case

* Change the package name after the discussion
  • Loading branch information
tomliked authored Feb 26, 2025
1 parent a494e49 commit 0f172a9
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/build-php-sdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,19 @@ jobs:
java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/tokens-api-model/tokens_2021-03-01.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\tokens\\v2021_03_01,apiPackage=Api\\tokens\\v2021_03_01 && \
java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/uploads-api-model/uploads_2020-11-01.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\uploads\\v2020_11_01,apiPackage=Api\\uploads\\v2020_11_01 && \
java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/vendor-direct-fulfillment-inventory-api-model/vendorDirectFulfillmentInventoryV1.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\vendor\\df\\inventory\\v1,apiPackage=Api\\vendor\\df\\inventory\\v1 && \
# Skipping Vendor DF Orders API due to error in model tags
# java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/vendor-direct-fulfillment-orders-api-model/vendorDirectFulfillmentOrders_2021-12-28.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\vendor\\df\\orders\\v2021_12_28,apiPackage=Api\\vendor\\df\\orders\\v2021_12_28 && \
java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/vendor-direct-fulfillment-orders-api-model/vendorDirectFulfillmentOrders_2021-12-28.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\vendor\\df\\orders\\v2021_12_28,apiPackage=Api\\vendor\\df\\orders\\v2021_12_28 && \
java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/vendor-direct-fulfillment-payments-api-model/vendorDirectFulfillmentPaymentsV1.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\vendor\\df\\payments\\v1,apiPackage=Api\\vendor\\df\\payments\\v1 && \
java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/vendor-direct-fulfillment-shipping-api-model/vendorDirectFulfillmentShipping_2021-12-28.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\vendor\\df\\shipping\\v2021_12_28,apiPackage=Api\\vendor\\df\\shipping\\v2021_12_28 && \
java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/vendor-direct-fulfillment-transactions-api-model/vendorDirectFulfillmentTransactions_2021-12-28.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\vendor\\df\\transactions\\v2021_12_28,apiPackage=Api\\vendor\\df\\transactions\\v2021_12_28 && \
java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/vendor-invoices-api-model/vendorInvoices.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\vendor\\invoices\\v1,apiPackage=Api\\vendor\\invoices\\v1 --skip-validate-spec && \
java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/vendor-orders-api-model/vendorOrders.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\vendor\\orders\\v1,apiPackage=Api\\vendor\\orders\\v1 && \
java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/vendor-shipments-api-model/vendorShipments.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\vendor\\shipments\\v1,apiPackage=Api\\vendor\\shipments\\v1 && \
java -jar openapi-generator-cli-7.9.0.jar generate -i ../../selling-partner-api-models/models/vendor-transaction-status-api-model/vendorTransactionStatus.json -g php -t config/templates -o sdk -c config/config.json --additional-properties=modelPackage=Model\\vendor\\transactionStatus\\v1,apiPackage=Api\\vendor\\transactionStatus\\v1
# This operation should be removed when vendorDirectFulfillmentOrders_2021-12-28.json is fixed
- name: Fix PHP vendorDirectFulfillmentOrders bool default value
working-directory: ./selling-partner-api-sdk/php/sdk
run: |
sed -i "s/?bool \$include_details = 'true'/?bool \$include_details = true/g" lib/Api/vendor/df/orders/v2021_12_28/VendorOrdersApi.php
- name: Create PR
uses: peter-evans/create-pull-request@v7
with:
Expand Down
5 changes: 0 additions & 5 deletions php/config/templates/TestHelper.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -620,11 +620,6 @@ class TestHelper
'testGetScheduledPackage200', // The expected and actual response is not a member of PackageStatus ENUM
'testListHandoverSlots400', // Due to Json structure is incorrect, need to be fixed
'testUpdateScheduledPackages400', // Due to Json structure is incorrect, need to be fixed
// DataKiosk
'testCancelQuery204', // Sandbox Returns 400
'testCancelQuery404', // Sandbox Returns 400
'testGetQuery200', // Sandbox Returns 400
'testGetQuery404', // Sandbox Returns 400
// Messaging API
// SandBox request timestamp format (2004-12-13T21:39:45.618-08:00) doesn't match with PHP.
// It will require dedicated customization to make 3 digit millisecond and doesn't match with auto Generation
Expand Down
4 changes: 2 additions & 2 deletions php/sdk/composer.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "spapi/sdk",
"name": "amzn/spapi-sdk",
"description": "Amazon Selling Partner APIs official client library for PHP.",
"type": "library",
"keywords": [
Expand All @@ -10,7 +10,7 @@
"php",
"rest"
],
"homepage": "https://developer-docs.amazon.com/sp-api",
"homepage": "https://github.com/amzn/selling-partner-api-sdk",
"license": "Apache-2.0",
"authors": [
{
Expand Down

0 comments on commit 0f172a9

Please sign in to comment.