-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add accessControl field to Android Compose template #1385
base: main
Are you sure you want to change the base?
Conversation
added accessControl to android compose template
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Awesome, can you add a changeset (patch I guess since this is a bugfix imo) by running I would also expect a test to now fail, or if there is no test for this format yet, could you add a test? |
@jorenbroekema I’ve followed the steps you provided and fixed the failing tests. I had to update the compose android snapshot as I also made a couple of formatting adjustments (semicolon after the package, a double space in the constructor, and a new line at the end of the file). Let me know if there’s anything else you need or if you have any further feedback! |
I added 2 more tests and some docs, let me know if this looks okay |
@jorenbroekema Yes, the tests you've added look great! Appreciate the hard work you put in |
added accessControl to android compose template
It seems that the accessControl field is not controlled in the Compose/Object template (Android), unlike in ios-swift/any.swift for example. It could be added to change the visibility of the created objects, thereby improving the simplicity of development in apps that use it.
Issue link here