Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ad9213 dev #2212

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ad9213 dev #2212

wants to merge 3 commits into from

Conversation

AndrDragomir
Copy link
Contributor

Add support for AD9213
Add devicetree for ad9213 + vcu118

@amiclaus amiclaus requested a review from a team June 19, 2023 11:26
Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the CI build issues in the first place. also the commits are pretty messed up. Do one commit for the driver inclusion, one for the dts, and one for the hmc (if needed). Also dt-bindings would be nice.

@nunojsa
Copy link
Collaborator

nunojsa commented Jun 19, 2023

Also dt-bindings would be nice

Will rephrase it to "a must" :) and the same goes for any non-standard ABI that the driver might introduce... Also from a quick look I had on the driver, make sure to use devm API so that you don't really need a .remove() for your driver

@SRaus SRaus changed the base branch from master to main January 9, 2024 09:50
@AndrDragomir
Copy link
Contributor Author

@dbogdan will take care of the changes

@nunojsa
Copy link
Collaborator

nunojsa commented Jun 5, 2024

@dbogdan, will anyone take care of this PR or should we close it for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants