iio: frequency: adf4030: fix possible unitialized 'ret' #2766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunojsa
requested review from
mhennerich,
dbogdan,
btogorean,
chegbeli,
buha,
amiclaus,
rbolboac,
danmois,
CiprianRegus and
machschmitt
as code owners
mhennerich
approved these changes
Apr 28, 2025
In adf4030_chan_dir_set(), every time 'initial' is false, 'ret' was being used uninitialized because we're ignoring the return value from regmap_update_bits(). Make sure we don't! Fixes: 54bbd40 ("iio: frequency: support the adf4030 Synchronizer") Signed-off-by: Nuno Sá <[email protected]>
nunojsa
force-pushed
the
staging/adf4030-fix
branch
from
147714c to
a98de6d
Compare
|
v2:
|
|
for some reason, the merge happened but the PR was not closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In adf4030_chan_dir_set(), every time 'initial' is false, 'ret' was being used unitialized because we're ignoring the return value from regmap_update_bits(). Make sure we don't!
Fixes: 54bbd40 ("iio: frequency: support the adf4030 Synchronizer")
PR Type
PR Checklist