Skip to content

ADSP-SC598 upstream driver changes v2 #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: adsp-6.12.38-y
Choose a base branch
from
Open

ADSP-SC598 upstream driver changes v2 #2908

wants to merge 25 commits into from

Conversation

artursartamonovsadi
Copy link

Minimal patch set to boot into ADSP-SC598-SOM with initramfs to UART Linux shell.
Based on v1 sent to kernel mailinglist. Tested with ADSP-SC598-SOM RevC

PR Type

  • Bug fix (a change that fixes an issue)
  • [x ] New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • [x ] I have conducted a self-review of my own code changes
  • [x ] I have tested the changes on the relevant hardware
  • [x ] I have updated the documentation outside this repo accordingly (if there is the case)

@artursartamonovsadi
arm64: Add ADI ADSP-SC598 SoC
25733e1 
Add ADSP-SC598 platform.

Co-developed-by: Utsav Agarwal <[email protected]>
Signed-off-by: Utsav Agarwal <[email protected]>
Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
dt-bindings: arm64: Add ADI ADSP-SC5xx pads driver
1a81e9f 
Support custom GPIO pin configuration for non-GPIO functions.

Co-developed-by: Utsav Agarwal <[email protected]>
Signed-off-by: Utsav Agarwal <[email protected]>
Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
reset: Add driver for ADI ADSP-SC5xx reset controller
398e640 
Adding support for ADI ADSP reset controller. This driver allows
trigger a software reset.

Co-developed-by: Utsav Agarwal <[email protected]>
Signed-off-by: Utsav Agarwal <[email protected]>
Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
dt-bindings: arm64: adi,sc598 bindings
db389de 
Bindigs for ADI ADSP-SC5xx reset controller

Co-developed-by: Utsav Agarwal <[email protected]>
Signed-off-by: Utsav Agarwal <[email protected]>
Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
dt-bindings: arm64: adi,sc598: Add ADSP-SC598 SoC bindings
9fe8055 
add  SoC ADSP-SC5xx

Signed-off-by: Utsav Agarwal <[email protected]>
Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
clock:Add driver for ADI ADSP-SC5xx PLL
194a02c 
Implements clock tree, no dynamic pll rate change.

Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
clock: Add driver for ADI ADSP-SC5xx clock
e219f29 
Add ADSP-SC5xx clock driver

Co-developed-by: Arturs Artamonovs <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
Signed-off-by: Utsav Agarwal <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
dt-bindings: clock: adi,sc5xx-clocks: add bindings
3085cc4 
Add ADSP-SC5xx clock bindings.

Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
gpio: add driver for ADI ADSP-SC5xx platform
ebf1d07 
Add ADSP-SC5xx GPIO driver.
- Support all GPIO ports
- Each gpio support seperate PINT interrupt controller

Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
dt-bindings: gpio: adi,adsp-port-gpio: add bindings
7e51db0 
Add ADSP-SC5xx GPIO driver bindings.

Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
pinctrl: Add drivers for ADI ADSP-SC5xx platform
2c4e844 
Add ADSP-SC5xx pinctrler:
 - Support switching GPIO pin functions.

Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
dt-bindings: pinctrl: adi,adsp-pinctrl: add bindings
2f36224 
Add PINCTRL driver bindings.

Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
i2c: Add driver for ADI ADSP-SC5xx platforms
81765f3 
Add support for I2C on SC5xx

Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
dt-bindings: i2c: add i2c/twi driver documentation
b24dbd6 
Add I2C driver bindings.

Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
serial: adi,uart: Add driver for ADI ADSP-SC5xx
f47734e 
Adding UART driver,supports all ADSP-SC5xx SoC family
- Support FIFO mode
- Support earlyprintk
- Support Enable Divide By One support, for higher clock resolutions.

Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
dt-bindings: serial: adi,uart4: add adi,uart4 driver documentation
c8ca6fb 
Add serial driver bindings.

Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
arm64: dts: adi: sc598: add device tree
ffbbd46 
Add ADI SC598-EZKIT device tree.
Support UART console as output.

Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
arm64: defconfig: sc598 add minimal changes
79cc01c 
Add ADSP-SC598 defconfig

Co-developed-by: Utsav Agarwal <[email protected]>
Signed-off-by: Utsav Agarwal <[email protected]>
Co-developed-by: Greg Malysa <[email protected]>
Signed-off-by: Greg Malysa <[email protected]>
Co-developed-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Nathan Barrett-Morrison <[email protected]>
Signed-off-by: Arturs Artamonovs <[email protected]>
@artursartamonovsadi
MAINTAINERS: add adi sc5xx maintainers
55b4443 
Add ADSP-SC598 maitaniners

Signed-off-by: Arturs Artamonovs <[email protected]>
@pamolloy pamolloy requested a review from gastmaier August 26, 2025 05:59
@pamolloy
Copy link
Collaborator

Thanks so much for posting this! @UtsavAgarwalADI and I were chatting about the sign off section for an earlier set of patches. It is probably easier to just discuss it in person, but also take a look at https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by. The two examples at the end of the section are especially helpful.

@pamolloy
Copy link
Collaborator

It would be good to link to the original mailing list review in the description:

https://lore.kernel.org/lkml/[email protected]/

pamolloy
pamolloy reviewed Aug 26, 2025
View reviewed changes
pamolloy
pamolloy reviewed Aug 26, 2025
View reviewed changes
arch/arm64/Kconfig.platforms
select COUNTER
help
This enables support for Analog Devices Incorporated's
Family of ARM64 DSP processors
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then maybe mention here ADSP-SC596 and ADSP-SC598 explicitly

pamolloy
pamolloy reviewed Aug 26, 2025
View reviewed changes
pamolloy
pamolloy reviewed Aug 26, 2025
View reviewed changes
drivers/clk/adi/clk.h
unsigned int id;
enum adi_clk_branch_type branch_type;
const char *name;
const char *const *parent_names; //should be const?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be addressed or removed

pamolloy
pamolloy reviewed Aug 26, 2025
View reviewed changes
drivers/clk/adi/clk.h
const char *const *parent_names; //should be const?
u8 num_parents;
unsigned long flags;
unsigned long offset; //void ** iomem offset?!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be addressed or removed

pamolloy
pamolloy reviewed Aug 26, 2025
View reviewed changes
@gastmaier
Copy link
Contributor

gastmaier commented Aug 28, 2025 •
edited
Loading

The ci runs on individual commits, in the context of as a series to be submitted.
Fixing the checkpatch warnings as a commit in the head won't fix the run, instead you do need to rewrite history, like a v2 submission.

You can even keep the cover letter commit, if you want

@artursartamonovsadi
Copy link
Author

Im also running the checkpatch locally to see whole picture.

pamolloy
pamolloy reviewed Sep 10, 2025
View reviewed changes
Documentation/devicetree/bindings/pinctrl/adi,sc5xx-pinctrl.yaml

"#size-cells":
const: 1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra whitespace here

@pamolloy
Copy link
Collaborator

Note the missing space in: clock:Add driver for ADI ADSP-SC5xx PLL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamolloy pamolloy pamolloy left review comments

@vasbimpikasadi vasbimpikasadi Awaiting requested review from vasbimpikasadi

@UtsavAgarwalADI UtsavAgarwalADI Awaiting requested review from UtsavAgarwalADI

@CalebEthridgeADI CalebEthridgeADI Awaiting requested review from CalebEthridgeADI

@nunojsa nunojsa Awaiting requested review from nunojsa nunojsa is a code owner

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

Assignees

@artursartamonovsadi artursartamonovsadi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artursartamonovsadi @pamolloy @gastmaier @nunojsa