Skip to content

Conversation

@Xenoamor
Copy link
Contributor

@Xenoamor Xenoamor commented Oct 1, 2025

Pull Request Description

In FDD mode if the Tx and Rx frequencies are the same (as is the case in the example code) then a null pointer is dereferenced as the SynthLUT *tab pointer is not initialised

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have complied with the Submission Checklist
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

@Xenoamor Xenoamor changed the title drivers:rf-transceiver:ad9361: Fix null pointer dereference in ad9361_rfpll_vco_init drivers: rf-transceiver: ad9361: Fix null pointer dereference in ad9361_rfpll_vco_init Oct 1, 2025
@buha
Copy link
Contributor

buha commented Oct 2, 2025

that makes sense, please do git commit --amend -s and add a brief description

i know in this case the title says it all but i'm more interested in the -s flag which adds the git name and email to the commit description, see 1st item in the checklist here https://analogdevicesinc.github.io/no-OS/contributing.html#submission-checklist

@buha
Copy link
Contributor

buha commented Oct 10, 2025

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please properly adjust your commit title and also add a body.
the commit title should have a prefix like rf-tranceiver: ad9361:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants