Skip to content

projects: ADE7816: Added readme doc #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

projects: ADE7816: Added readme doc #2782

wants to merge 1 commit into from

Conversation

@jvelasc2
Copy link
Contributor

@jvelasc2 jvelasc2 commented Oct 13, 2025 •
edited
Loading

projects: ADE7816: Added readme doc

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have complied with the Submission Checklist
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

@jvelasc2 jvelasc2 marked this pull request as ready for review October 13, 2025 06:35
RaduSabau1
RaduSabau1 reviewed Oct 15, 2025
View reviewed changes
projects/ade7816/README.rst Outdated
~~~~~~~~~~~~~~~~~~~~~~~~~~

+-----------------------+-----------------------+-----------------------+
| **Pin Function** | **EVAL-ADE7816 | **MAX32690EVKIT** |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this project example AD-APARD32690-SL was used instead of MAX32690EVKIT, please apply the same change in the other occurrences as well.

RaduSabau1
RaduSabau1 reviewed Oct 15, 2025
View reviewed changes
projects/ade7816/README.rst Outdated
| **Pin Function** | **EVAL-ADE7816 | **MAX32690EVKIT** |
| | Evaluation Board** | |
+-----------------------+-----------------------+-----------------------+
| MOSI | Pin 10 (U2) - Master | Pin 45 (P3.0) - |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since SPI Device 4 was used for this project, the pins are wrong for the whole SPI communication, refer to the AD-APARD32690-SL schematic for the correct pin numbers.

RaduSabau1
RaduSabau1 reviewed Oct 15, 2025
View reviewed changes
@jvelasc2 jvelasc2 force-pushed the ade7816-proj-readme branch from 56b3ea1 to 07daf82 Compare October 17, 2025 02:57
RaduSabau1
RaduSabau1 reviewed Oct 21, 2025
View reviewed changes
projects/ade7816/README.rst
.. code-block:: bash

# Enable the basic example project
basic_example_max32690 TARGET=max32690
Copy link
Collaborator

@RaduSabau1 RaduSabau1 Oct 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writing this in the Makefile results in an error. Since this project only has the basic_example to it, no extra configuration is really needed in the Makefile, but I guess something like this could still be used in the documentation if you want to mention the Makefile configuration :

no-OS/projects/adf4371/README.rst

Line 340 in e6569fe

EXAMPLE ?= basic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RaduSabau1 RaduSabau1 RaduSabau1 left review comments

@amiclaus amiclaus amiclaus approved these changes

@buha buha Awaiting requested review from buha buha is a code owner

@CiprianRegus CiprianRegus Awaiting requested review from CiprianRegus CiprianRegus is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@rbolboac rbolboac Awaiting requested review from rbolboac rbolboac is a code owner

@danmois danmois Awaiting requested review from danmois danmois is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jvelasc2 @amiclaus @RaduSabau1