Skip to content

Conversation

@jansunil
Copy link
Collaborator

@jansunil jansunil commented Oct 16, 2025

Added driver, example project and documentation for MAX22007

Added a new API in the no_os_crc.c/.h to populate CRC table with LSB first logic

Pull Request Description

Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have complied with the Submission Checklist
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

SPI Read Operation
image

SPI Write Operation
image

@jansunil jansunil force-pushed the max22007-dev branch 5 times, most recently from 9e41b68 to e9b599b Compare October 17, 2025 10:33
@jansunil jansunil marked this pull request as ready for review October 17, 2025 10:34
Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prior to the in-depth review, please separate your commits into: driver implementation, driver documentation, project implementation, project documentation. Also the crc implementation should be in its own commit.
Example: https://github.com/analogdevicesinc/no-OS/pull/2429/commits

@jansunil jansunil force-pushed the max22007-dev branch 4 times, most recently from c31703a to 26f99ce Compare October 17, 2025 12:48
Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks solid overall, minor comments inline.

@jansunil jansunil force-pushed the max22007-dev branch 3 times, most recently from ccb4baf to e2c0d9b Compare October 22, 2025 07:29
Add LSB first implementation for populating CRC table

Signed-off-by: Janani Sunil <[email protected]>
@jansunil
Copy link
Collaborator Author

jansunil commented Nov 6, 2025

Changelog v2:

  1. Modified the bit mask implementation from (NO_OS_BIT(12) << (channel)) to NO_OS_BIT(12 + channel) in three instances
  2. Corrected the sequence of CRC configuration with respect to soft reset command
  3. Removed redundant hardcoding of crc_en in the initialization function.

amiclaus
amiclaus previously approved these changes Nov 6, 2025
@jansunil
Copy link
Collaborator Author

jansunil commented Nov 7, 2025

Changelog v3:

  1. Updated revision ID checks to include ID for both Rev0 and Rev1

@jansunil jansunil requested a review from rbudai98 November 7, 2025 08:17
Add driver support for MAX22007

Signed-off-by: Janani Sunil <[email protected]>
Add driver documentation for MAX22007

Signed-off-by: Janani Sunil <[email protected]>
Add basic example project for MAX22007

Add make based CI build support

Signed-off-by: Janani Sunil <[email protected]>
Add documentation for MAX22007 example project

Signed-off-by: Janani Sunil <[email protected]>
@jansunil
Copy link
Collaborator Author

jansunil commented Nov 7, 2025

Changelog v4:

  1. Corrected the logic to check for multiple REV IDs

@jansunil jansunil merged commit 6dc4674 into main Nov 10, 2025
15 of 17 checks passed
@jansunil jansunil deleted the max22007-dev branch November 10, 2025 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants