-
Notifications
You must be signed in to change notification settings - Fork 1.8k
drivers:dac:Add support for MAX22007 #2787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9e41b68 to
e9b599b
Compare
e9b599b to
478f10d
Compare
amiclaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prior to the in-depth review, please separate your commits into: driver implementation, driver documentation, project implementation, project documentation. Also the crc implementation should be in its own commit.
Example: https://github.com/analogdevicesinc/no-OS/pull/2429/commits
c31703a to
26f99ce
Compare
amiclaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks solid overall, minor comments inline.
ccb4baf to
e2c0d9b
Compare
e2c0d9b to
4ad00bc
Compare
4ad00bc to
76237b8
Compare
Add LSB first implementation for populating CRC table Signed-off-by: Janani Sunil <[email protected]>
76237b8 to
b2330a3
Compare
|
Changelog v2:
|
b2330a3 to
6987281
Compare
|
Changelog v3:
|
Add driver support for MAX22007 Signed-off-by: Janani Sunil <[email protected]>
Add driver documentation for MAX22007 Signed-off-by: Janani Sunil <[email protected]>
Add basic example project for MAX22007 Add make based CI build support Signed-off-by: Janani Sunil <[email protected]>
Add documentation for MAX22007 example project Signed-off-by: Janani Sunil <[email protected]>
6987281 to
6ed3f1f
Compare
|
Changelog v4:
|
Added driver, example project and documentation for MAX22007
Added a new API in the no_os_crc.c/.h to populate CRC table with LSB first logic
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist
SPI Read Operation

SPI Write Operation
