drivers:adc:ltc2378: Add support for LTC2378-20 #2794

csarip · 2025-10-22T03:14:30Z

Pull Request Description

This PR adds initial driver support for the LTC2378-20 20-bit SAR ADC with project examples.

Driver Features Implemented:

SPI Communication: 20-bit data acquisition with CNV/BUSY handshake protocol
Input Modes: Unipolar (0 to VREF) and bipolar (±VREF) configuration support
Data Conversion: Raw ADC reading and raw-to-microvolts conversion functions
Power Management: Manual power-down control via CNV signal

Project Examples Added:

Platform: Maxim MAX32666FTHR evaluation board with DC2135A board
Test: Validates SPI communication, ADC conversion, unipolar/bipolar modes, and voltage scaling
Hardware Validation: Tested on actual MAX32666FTHR hardware with DC2135A board

PR Type

Bug fix (change that fixes an issue)
New feature (change that adds new functionality)
Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

I have followed the Coding style guidelines
I have complied with the Submission Checklist
I have performed a self-review of the changes
I have commented my code, at least hard-to-understand parts
I have build all projects affected by the changes in this PR
I have tested in hardware affected projects, at the relevant boards
I have signed off all commits from this PR
I have updated the documentation (wiki pages, ReadMe etc), if applies

csarip · 2025-10-23T02:04:10Z

It appears to have the same failed checks as PR #2783. Unless all checks are required to pass, this PR is ready for review.

amiclaus

looks good overall, but the documentation issues ar valid. check for the warnings in the log file, those are treated as errors too.

drivers/adc/ltc2378/ltc2378.c

drivers/adc/ltc2378/iio_ltc2378.c

jemfgeronimo

Some minor changes. The main change is to use the new example infrastructure.
Reference commits: 39e2d46, 81c90dc, 913998c
Reference PRs: #2795, #2421

drivers/adc/ltc2378/ltc2378.c

projects/ltc2378/builds.json

csarip · 2025-10-28T08:56:02Z

v2:

Fixed declarations and brackets
Changed to new example infrastructure

jemfgeronimo

Some changes to fix the LinuxBuilds documentation errors.

drivers/adc/ltc2378/README.rst

projects/ltc2378/README.rst

csarip · 2025-10-29T02:42:26Z

v3:

Added fixes to docs
Fixed commit messages

jemfgeronimo

Some minor changes.

drivers/adc/ltc2378/ltc2378.c

drivers/adc/ltc2378/iio_ltc2378.c

projects/ltc2378/src/common/common_data.c

projects/ltc2378/src/platform/maxim/parameters.h

Add initial header and source files for LTC2378 driver. Signed-off-by: Cherrence Sarip <[email protected]>

Add initial header and source file for LTC2378 IIO driver. Signed-off-by: Cherrence Sarip <[email protected]>

Add README.rst documentation file for LTC2378 alongside other documentation related files. Signed-off-by: Cherrence Sarip <[email protected]>

Add initial project files for both basic and IIO examples for LTC2378. Signed-off-by: Cherrence Sarip <[email protected]>

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Cherrence Sarip <[email protected]>

csarip · 2025-10-30T03:01:11Z

v4:

Fixed IIO error handling by replacing sentinel values with proper error codes
Removed magic numbers by adding descriptive macros
Used no-OS utility functions for sign extension

jemfgeronimo

Just a minor change. Otherwise, LGTM.

jemfgeronimo · 2025-11-03T00:39:07Z

drivers/adc/ltc2378/README.rst

+* ``scale`` - The scale factor to convert raw values to millivolts
+* ``processed`` - The processed voltage value in millivolts (raw * scale)


You used microvolts in your driver.

csarip requested review from CiprianRegus, amiclaus, buha, danmois, dbogdan and rbolboac as code owners October 22, 2025 03:14

csarip force-pushed the dev/ltc2378-20 branch 3 times, most recently from 8e480e9 to e1c00ca Compare October 22, 2025 07:43

jemfgeronimo self-requested a review October 24, 2025 07:33

amiclaus reviewed Oct 24, 2025

View reviewed changes

drivers/adc/ltc2378/ltc2378.c Outdated Show resolved Hide resolved

drivers/adc/ltc2378/iio_ltc2378.c Show resolved Hide resolved

drivers/adc/ltc2378/iio_ltc2378.c Outdated Show resolved Hide resolved

csarip force-pushed the dev/ltc2378-20 branch from e1c00ca to 118b0d2 Compare October 28, 2025 04:03

jemfgeronimo reviewed Oct 28, 2025

View reviewed changes

drivers/adc/ltc2378/ltc2378.c Show resolved Hide resolved

projects/ltc2378/builds.json Outdated Show resolved Hide resolved

csarip force-pushed the dev/ltc2378-20 branch from 118b0d2 to 9f4765c Compare October 28, 2025 05:39

csarip marked this pull request as draft October 28, 2025 06:02

csarip force-pushed the dev/ltc2378-20 branch from 9f4765c to 67b68ba Compare October 28, 2025 08:53

jemfgeronimo self-requested a review October 28, 2025 09:08

jemfgeronimo reviewed Oct 29, 2025

View reviewed changes

drivers/adc/ltc2378/README.rst Outdated Show resolved Hide resolved

projects/ltc2378/README.rst Outdated Show resolved Hide resolved

csarip force-pushed the dev/ltc2378-20 branch from 67b68ba to 36f7683 Compare October 29, 2025 02:21

csarip marked this pull request as ready for review October 29, 2025 02:24

csarip force-pushed the dev/ltc2378-20 branch from 36f7683 to 850761a Compare October 29, 2025 02:41

jemfgeronimo mentioned this pull request Oct 29, 2025

Add support for MAX17616 #2734

Open

11 tasks

jemfgeronimo reviewed Oct 30, 2025

View reviewed changes

csarip marked this pull request as draft October 30, 2025 01:53

csarip added 3 commits October 30, 2025 10:56

drivers: adc: ltc2378: Add driver support for LTC2378

1df79cf

Add initial header and source files for LTC2378 driver. Signed-off-by: Cherrence Sarip <[email protected]>

drivers: adc: ltc2378: Add IIO support for LTC2378

6737e6e

Add initial header and source file for LTC2378 IIO driver. Signed-off-by: Cherrence Sarip <[email protected]>

drivers: adc: ltc2378: Add README documentation for LTC2378

9c99e4d

Add README.rst documentation file for LTC2378 alongside other documentation related files. Signed-off-by: Cherrence Sarip <[email protected]>

csarip added 2 commits October 30, 2025 10:56

projects: ltc2378: Add project for LTC2378

c5a3449

Add initial project files for both basic and IIO examples for LTC2378. Signed-off-by: Cherrence Sarip <[email protected]>

projects: ltc2378: Add README documentation for project

71f0c5e

Add README.rst documentation file for project alongside other documentation related files. Signed-off-by: Cherrence Sarip <[email protected]>

csarip force-pushed the dev/ltc2378-20 branch from 850761a to 71f0c5e Compare October 30, 2025 02:57

csarip marked this pull request as ready for review October 30, 2025 03:01

jemfgeronimo reviewed Nov 3, 2025

View reviewed changes

		* ``scale`` - The scale factor to convert raw values to millivolts
		* ``processed`` - The processed voltage value in millivolts (raw * scale)

drivers:adc:ltc2378: Add support for LTC2378-20 #2794

Are you sure you want to change the base?

drivers:adc:ltc2378: Add support for LTC2378-20 #2794

Uh oh!

Conversation

csarip commented Oct 22, 2025

Pull Request Description

Driver Features Implemented:

Project Examples Added:

PR Type

PR Checklist

Uh oh!

csarip commented Oct 23, 2025

Uh oh!

amiclaus left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jemfgeronimo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

csarip commented Oct 28, 2025

Uh oh!

jemfgeronimo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

csarip commented Oct 29, 2025

Uh oh!

jemfgeronimo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

csarip commented Oct 30, 2025

Uh oh!

jemfgeronimo left a comment

Choose a reason for hiding this comment

Uh oh!

jemfgeronimo Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants