Skip to content

platform: stm32: fix SPI DMA timeout underflow #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morleman1 wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −7
Open

platform: stm32: fix SPI DMA timeout underflow #3116

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca24fef
platform: stm32: fix SPI DMA timeout underflow
morleman1 Jun 1, 2026
d284e42
platform: stm32: fix SPI DMA timeout underflow
morleman1 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions drivers/platform/stm32/stm32_spi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,16 +672,18 @@ int32_t stm32_spi_transfer_dma(struct no_os_spi_desc* desc,
sdesc->stm32_spi_dma_done = false;
stm32_config_dma_and_start(desc, msgs, len, stm32_spi_dma_callback, desc);
timeout = msgs->bytes_number;
while (timeout--) {
while (timeout > 0) {
no_os_mdelay(1);
if (sdesc->stm32_spi_dma_done)
break;
timeout--;
};

/* need some cleanup here? */
if (timeout == 0)
/* Fix: Check the actual completion flag instead of the counter */
Comment thread
morleman1 marked this conversation as resolved.
Outdated
if (!sdesc->stm32_spi_dma_done) {
/* Optional: Add HAL_DMA_Abort_IT() or similar cleanup here */
Copy link
Copy Markdown
Contributor

@buha buha Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this comment as well

Copy link
Copy Markdown
Author

@morleman1 morleman1 Jun 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i reverted to the original comment /* need some cleanup here? */, as a cleanup still should be implemented similar to the xspi implementation. here it is more complex, because of seperate handles for rx and txdma_ch

Copy link
Copy Markdown
Contributor

@buha buha Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, just squash the commits for now into a single commit and leave the original question there. We can deal with that separately in another PR and merge this one.

return -ETIME;

}
return 0;
}

Expand Down
Loading