Skip to content

Conversation

@tfcollins
Copy link
Collaborator

Description

PR adds features for calibration export and loading. Include:

  • CLI tool for export, loading, and reading calibration files
  • Method for AD9084 to load/export and check calibration
  • Tests for AD9084 new methods

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

New tests add for methods

Test Configuration:

  • Hardware: AD9084+VPK180
  • OS: Ubuntu 24.04

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tfcollins tfcollins requested a review from mhennerich December 1, 2025 18:35
@tfcollins tfcollins changed the title Tfcollins/ad9084 cal loading AD9084 cal loading Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Test Results

1 726 tests  +1     470 ✅ ±0   12m 5s ⏱️ -1s
    1 suites ±0   1 256 💤 +1 
    1 files   ±0       0 ❌ ±0 

Results for commit 58155fa. ± Comparison against base commit 935357e.

This pull request removes 4 and adds 5 tests. Note that renamed tests count towards both.
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[10.5, 22.0, 1.5, 2.0, 0.5, 9.5, 9.5, 14.0, 32.5, 8.0]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[13.5, 30.0, 3.0, 21.0, 19.0, 10.0, 6.5, 33.0, 16.0, 5.0]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-17.55, -35.4, -24.15, -24.0, -34.1, -28.7, -14.35, -29.4, -8.45, -28.7]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-34.1, -10.85, -18.6, -25.95, -14.4, -22.7, -17.0, -37.85, -5.55, -24.65]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]
test.test_ad9084 ‑ test_ad9084_adc_jesd_calibrations
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[20.0, 6.5, 7.0, 15.0, 24.0, 26.5, 21.0, 14.0, 25.0, 15.5]-depends={'gain_control_mode_chan1': 'spi', 'rx_ensm_mode_chan1': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=rx_hardwaregain_chan0-val=[26.0, 7.5, 24.5, 18.5, 33.5, 5.0, 7.5, 26.0, 16.0, 28.5]-depends={'gain_control_mode_chan0': 'spi', 'rx_ensm_mode_chan0': 'rf_enabled'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan0-val=[-5.4, -30.75, -16.75, -12.05, -26.35, -25.5, -19.45, -26.85, -30.95, -22.0]-depends={'atten_control_mode_chan0': 'spi'}-classname=adi.adrv9002]
test.test_adrv9002_p ‑ test_adrv9002_hardware_gain[attr=tx_hardwaregain_chan1-val=[-1.9, -33.95, -17.0, -18.15, -30.15, -39.95, -20.85, -24.4, -21.4, -32.5]-depends={'atten_control_mode_chan1': 'spi'}-classname=adi.adrv9002]

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Generated documentation for this PR is available at Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants