PARTIAL: Support testing ResolutionException #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*This patch is incomplete!* The goal of this patch is to allow Test262 tests to express `negative: SyntaxError` for module loading errors such as ambiguous import bindings. With this patch applied, the test runner fails with messages like this: > Expected: (((an instance of com.github.anba.es6draft.parser.ParserException or an instance of com.github.anba.es6draft.compiler.CompilationException or an instance of java.lang.StackOverflowError or an instance of com.github.anba.es6draft.runtime.modules.ResolutionException) or an instance of com.github.anba.es6draft.runtime.internal.ScriptException) and exception with error-message string matching 'SyntaxError') > but: exception with error-message string matching 'SyntaxError' error-message was "ambiguous export \"x\"" > Stacktrace was: com.github.anba.es6draft.runtime.modules.ResolutionException: ambiguous export "x" > [...]
|
I've found a solution that technically works, though it's guaranteed to make you cringe :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is incomplete!
The goal of this patch is to allow Test262 tests to express
negative: SyntaxErrorfor module loading errors such as ambiguous importbindings.
With this patch applied, the test runner fails with messages like this:
@anba Do you have any advice for how to proceed?