Community patches roll-up #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You will need to bump the minimum Rust version in |
|
Could you edit that? I'm far away from any laptop.
…On Wed, Aug 30, 2017 at 7:21 AM Doug Goldstein ***@***.***> wrote:
You will need to bump the minimum Rust version in .travis.yml to match
what num_traits requires, which based on the errors appears to be 1.8.0.
I think at this point its ok to do so given how old 1.0.0 and 1.8.0 are.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANsMEhUXc_IwfcHnPSTCCQQ-t_LdjR6ks5sdW_ZgaJpZM4PBVW1>
.
|
|
I'm not the author nor do I have commit access. |
Signed-off-by: Barry Allard <[email protected]>
|
@cardoe Oh well, thanks for noticing it. I was in the desert, but not doing Burning Man this year though. I'll play this for myself cryin' in my beer ;) 🤘 |
cardoe
approved these changes
Sep 3, 2017
src/lib.rs
Outdated
| @@ -53,7 +53,7 @@ | |||
| //! ``` | |||
|
|
|||
|
|
|||
| extern crate num_traits; | |||
| pub extern crate num_traits; | |||
There was a problem hiding this comment.
Is this really necessary to be public? We only need FromPrimitive which is already public.
There was a problem hiding this comment.
Noticed the same behavior is done in #11 but I still don't think its needed.
|
Yes, it doesn't appear to add anything of value. |
cardoe
reviewed
Sep 6, 2017
| @@ -28,8 +28,7 @@ wrap your `enum` declaration inside the `enum_from_primitive!` macro. | |||
|
|
|||
| ```rust | |||
| #[macro_use] extern crate enum_primitive; | |||
| extern crate num; | |||
| use num::FromPrimitive; | |||
| use enum_primitive::num_traits::FromPrimitive; | |||
| //! use num_traits::FromPrimitive; | ||
| //! #[macro_use] | ||
| //! extern crate enum_primitive; | ||
| //! use enum_primitive::num_traits::FromPrimitive; |
ctrlcctrlv
added a commit
to MFEK/enum_primitive.rlib
that referenced
this pull request
Nov 14, 2021
ctrlcctrlv
added a commit
to MFEK/enum_primitive.rlib
that referenced
this pull request
Nov 14, 2021
ctrlcctrlv
added a commit
to MFEK/enum_primitive.rlib
that referenced
this pull request
Nov 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boils down community improvements into a tiny mega PR.