improve get with params performance #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I make small improvement to your already awesome project. I change the empty method to isset and get parameter from $vars=array() to $vars=null. My testing method is simple, i use for loops to calls $curl->get() function 10 times and count how long the operation is. This is my test result: Kindly check please XD |
Delete some residual benchmark
Delete residual debug
|
hi @ekharisma, thanks for the PR, I will review it as soon as possible |
|
Thank you
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Andhika Yuana ***@***.***>
Sent: Saturday, July 10, 2021 7:25:14 PM
To: andhikayuana/curl-lib ***@***.***>
Cc: ekharisma ***@***.***>; Mention ***@***.***>
Subject: Re: [andhikayuana/curl-lib] improve get with params performance (#4)
hi @ekharisma<https://github.com/ekharisma>, thanks for the PR, I will review it as soon as possible
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#4 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APTCRZ3Y5MRHQUOCEMLZJ7LTXA32VANCNFSM47LUPRRA>.
|
| @@ -0,0 +1 @@ | |||
| ,DESKTOP-2GSR8J5/Ekky,DESKTOP-2GSR8J5,27.06.2021 02:24,file:///C:/Users/Ekky/AppData/Roaming/LibreOffice/4; No newline at end of file | |||
There was a problem hiding this comment.
please remove this file @ekharisma
There was a problem hiding this comment.
and please Hasil.ods file convert to results.csv file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.