split define_recv_packets! into a separate module#48
Merged
andrei-ng merged 8 commits intoandrei-ng:mainfrom Mar 11, 2025
CramBL:macro-fix
Merged
split define_recv_packets! into a separate module#48andrei-ng merged 8 commits intoandrei-ng:mainfrom CramBL:macro-fix
andrei-ng merged 8 commits intoandrei-ng:mainfrom
CramBL:macro-fix
Conversation
Owner
|
@CramBL , I will merge this in main after I have a look how you solved the problem. But as per the discussion in the upstream repo, let's team up there. |
Owner
Thank you for the pointers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #47
Part of addressing #19
split
define_recv_packets!into a separate module as mentioned in a TODO.The problem in the previous attempt (as described in the TODO) was related to the proc macros declaring the exact path to certain types like
FieldIterandPacketSerializer.You could "fix" it by adjusting the path to the new place where
PacketSerializernow is, but the better choice is to avoid declaring such things in a macro and that's what I did.Bump MSRV to 1.81.0
That's when "reasons" in allow lints was stabilized. I think it's an important feature for long term maintenance.
Added
test.shscriptFor convenience to check locally if CI is OK.
I would use just for these things if it was up to me. What do you think about using just?