Use preferred_protocols and refactor matching loop in issuance_main#213
Open
netheril96 wants to merge 1 commit into
Open
Use preferred_protocols and refactor matching loop in issuance_main#213netheril96 wants to merge 1 commit into
netheril96 wants to merge 1 commit into
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Collaborator
Author
|
Note: don't merge this PR as of now because it has a diffbase. Give me comments or approval instead. |
Renamed allowed_protocols to preferred_protocols in IssuanceMatcherData. Updated matching logic: - If preferred_protocols is set, we match in order of preference. - Record the matched request index as ridx in the metadata. Refactored the matching loop in issuance_main using iterator combinators (find_map, find) for better readability. Updated existing tests and added a new test match_preferred_protocol_order to verify preference ordering and ridx recording. TAG=agy CONV=6222f947-d807-4f7a-8223-5f30b7376340
netheril96
force-pushed
the
wasm-pr-preferred-protocols
branch
from
July 23, 2026 13:51
2dd3e6b to
8190292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed allowed_protocols to preferred_protocols in IssuanceMatcherData. Updated matching logic: if preferred_protocols is set, we match in order of preference; record the matched request index as pidx in the metadata. Refactored the matching loop in issuance_main using iterator combinators (find_map, find) for better readability. Updated existing tests and added a new test match_preferred_protocol_order to verify preference ordering and pidx recording.
TAG=agy
CONV=6222f947-d807-4f7a-8223-5f30b7376340