Update Gradle wrapper to 6.7.1 #106
Conversation
Updated by running this command: `./gradlew wrapper``
Summary of ChangesHello @cartland, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates the Gradle wrapper to version 6.7.1 for the BiometricAuthentication, BiometricLoginKotlin, and DirectBoot projects. The update ensures that these projects leverage the latest features and improvements of Gradle 6.7.1, and standardizes the wrapper scripts by incorporating automatically generated changes for better maintainability and compatibility across different operating systems. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Gradle wrapper files across multiple projects. While the title suggests an update to version 6.7.1, the version was already set. The main changes are updating the gradlew and gradlew.bat scripts to a more modern and portable version, and changing the Gradle distribution type from -all to -bin. The script updates are solid improvements. However, I've added comments recommending to revert the switch to the -bin distribution. While it offers performance benefits by reducing download size, it removes access to Gradle's source code, which can be valuable for developers, especially in a repository with sample projects. Please review these comments.
| #Mon Oct 07 10:54:41 PDT 2019 | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-bin.zip |
There was a problem hiding this comment.
The Gradle distribution type was changed from all to bin. The bin distribution is smaller, which is good for CI, but it lacks Gradle sources and documentation. For local development, the all distribution is often preferred as it allows IDEs to provide better support, like navigating to Gradle source code. Given that this repository contains sample projects, retaining the all distribution would be better for developers exploring the code. It is recommended to revert this change. To generate the wrapper with the all distribution in the future, you can run ./gradlew wrapper --distribution-type all.
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-all.zip
| #Thu Feb 27 09:22:57 PST 2020 | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-bin.zip |
There was a problem hiding this comment.
The Gradle distribution type was changed from all to bin. The bin distribution is smaller, which is good for CI, but it lacks Gradle sources and documentation. For local development, the all distribution is often preferred as it allows IDEs to provide better support, like navigating to Gradle source code. Given that this repository contains sample projects, retaining the all distribution would be better for developers exploring the code. It is recommended to revert this change. To generate the wrapper with the all distribution in the future, you can run ./gradlew wrapper --distribution-type all.
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-all.zip
| #Thu Jul 18 14:56:29 PDT 2019 | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-bin.zip |
There was a problem hiding this comment.
The Gradle distribution type was changed from all to bin. The bin distribution is smaller, which is good for CI, but it lacks Gradle sources and documentation. For local development, the all distribution is often preferred as it allows IDEs to provide better support, like navigating to Gradle source code. Given that this repository contains sample projects, retaining the all distribution would be better for developers exploring the code. It is recommended to revert this change. To generate the wrapper with the all distribution in the future, you can run ./gradlew wrapper --distribution-type all.
distributionUrl=https\://services.gradle.org/distributions/gradle-6.7.1-all.zip
1 participant
Updated by running this command:
./gradlew wrapper