Deprecate Util.SDK_INT in favor of Build.VERSION.SDK_INT
#2285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
force-pushed
the
deprecate_util_sdkint
branch
6 times, most recently
from
bbb8d60 to
4b6edd6
Compare
MGaetan89
force-pushed
the
deprecate_util_sdkint
branch
3 times, most recently
from
59780a8 to
59bd21d
Compare
|
Thanks for trying to replace all these usages :) The value was in fact not only used for Robolectric, but also to allow special logic for pre-releases of Android that don't have a real version number yet. We haven't used this field for that purpose in years though, and if we wanted to, we could just use a more localized check while the pre-release hasn't got its new number. |
`Util.SDK_INT` was introduced to be able to simulate any SDK version during tests. This is possible by using Robolectric's `@Config(sdk)` annotation. All usages of `Util.SDK_INT` have been replaced by `Build.VERSION.SDK_INT`. This is a similar change to what was done in androidx#2107.
tonihei
force-pushed
the
deprecate_util_sdkint
branch
from
59bd21d to
bfa8c0d
Compare
tonihei
force-pushed
the
deprecate_util_sdkint
branch
from
bfa8c0d to
340264e
Compare
Deprecatations don't need to be noted
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Util.SDK_INTwas introduced to be able to simulate any SDK version during tests. This is possible by using Robolectric's@Config(sdk)annotation.All usages of
Util.SDK_INThave been replaced byBuild.VERSION.SDK_INT.This is a similar change to what was done in #2107.