Skip to content

c2.sec.flac.decoder does not support 32-bit audio on Android 14 #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nift4
Copy link

@nift4 nift4 commented Jun 29, 2025

fixes 32-bit FLAC playback on Galaxy S23 FE (Snapdragon 8 Gen 1 version)

@microkatz microkatz self-requested a review July 4, 2025 13:54
@microkatz microkatz self-assigned this Jul 4, 2025
nift4 and others added 2 commits July 8, 2025 10:42
fixes 32-bit FLAC playback on Galaxy S23 FE (Snapdragon 8 Gen 1 version)
@microkatz
Copy link
Contributor

microkatz commented Jul 8, 2025

@nift4

Thank you for submitting your PR request!

If I may ask, do you know or did you test if the c2.sec.flac.decoder actually supports 32-bit audio on Android 15? Or is the purpose of this PR to make devices on 34 utilize the c2.android.flac.decoder? If the latter, then this PR is just a patch and not a full fix.

@nift4
Copy link
Author

nift4 commented Jul 8, 2025

I don't have physical access to a newer OneUI device for testing, but because I didn't get bug reports about newer versions, I assumed it was working.

However your question inspired me to test on Firebase Test Lab, and the newest available device there (S25 Ultra on Android 15) still didn't have working 32-bit FLAC playback.

Should I change the check to return false no matter which SDK if c2.sec.flac.decoder is queried, or do you want to push a commit that does that? (Asking because I don't want to mess up the merge process, not sure if you already started it.)

@nift4
Copy link
Author

nift4 commented Jul 9, 2025

@microkatz
I have edited the PR. Now, it should be a full fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants