Skip to content

Added TOTP Feature #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Added TOTP Feature #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1bb8e82
Added TOTP Feature
arg3t Mar 16, 2021
b71089c
Dmenu password patch
arg3t Mar 17, 2021
e6c80d4
Fixed PR issues, edited readme for dmenu patch
arg3t Mar 19, 2021
148dad9
README typo
arg3t Mar 19, 2021
015c0c0
Exchanging speed for security, but its worth it IMO
Mar 21, 2021
832850c
Manueal sync from dmenu
Mar 21, 2021
d4a39a3
Fixed bug while on sync
arg3t Mar 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ little more lenient. Here is the command I use in my personal i3wm config.
bitwarden-dmenu --dmenu-args='-i' --clear-clipboard 30 --session-timeout 100 --sync-vault-after 3600 --on-error 'xargs notify-send --urgency=low'
```

If you have the [password patch](https://tools.suckless.org/dmenu/patches/password/) for dmenu, you can run the following command to see your password as you enter it:
Copy link
Owner

@andykais andykais Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm...I dont love this. I think its best to keep out of the readme. If you took the time to install the password patch, you probably already know to use it. As an alternative though, is it possible to programatically detect this? E.g. can we detect that the -P flag is available by calling dmenu -h and doing a text search? That would avoid the necessity for users to manually set things, and I doubt they would ever not want this flag

Copy link
Author

@arg3t arg3t Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text search of dmenu -h might not work for some people. For instance, if a patch fails and I have to manually add it, I just don't bother with editing the help message. This is the case in my current dmenu setup as well. We could just run dmenu -P and check whether that spits an error, but if the command has that option it will wait for user input before returning an exit code and that is not ideal either. We can just leave it as is right now and allow people to manually set it. If I ever find a solution though I will submit another pull request.

```bash
bitwarden-dmenu --dmenu-args='-i' --dmenu-pswd-args='-nf white -P' --clear-clipboard 30 --session-timeout 100 --sync-vault-after 3600 --on-error 'xargs notify-send --urgency=low'
```

`bitwarden-dmenu` will prompt for a login if you are logged out.

## Installation
Expand Down
1 change: 0 additions & 1 deletion bin/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ async function runBitwardenDmenu() {
oldestAllowedVaultSync,
unsafeDebug
})

return { lockBitwardenAfter: sessionTimeout, clearClipboardAfter }
} catch (e) {
if (e instanceof CancelError) {
Expand Down
Loading