Update dependencies + test on Node>10 compatible dependencies #300

aminya · 2020-09-07T13:33:18Z

This updates all the dependencies
- This means that the tests will run on Node>10 compatible dependencies
- This will unblock other PRs such as feat: support choosing custom worker backend #290 that were failing due to old build tools
Tests threads-js on Node 10-14 via GitHub Actions

~~- rollup-script and ava-script are used to make it possible to run the tests on old Node versions.~~

aminya · 2020-09-07T14:32:41Z

Bundle command fails on Node 8 because TypeScript generates import in the ESM output, and you are trying to bundle the Code from the output of TypeScript. Instead, you can use a Rollup-TypeScript plugin to bundle the code from the beginning.

aminya · 2020-09-13T00:18:01Z

I reverted using Parcel because of parcel-bundler/parcel#5135

andywer · 2020-09-13T08:15:23Z

Side note: You definitely need to keep rollup. Not necessarily for bundling, but just to make sure that our ES module output can be consumed by rollup, since we had issues with rollup in the past 😉

aminya · 2020-09-16T06:50:52Z

Well currently, using the new Rollup people cannot build threads on Node 8.

Do you want us to use a Pre Node 10 rollup script for that?

As you see in https://travis-ci.org/github/andywer/threads.js/jobs/726678405#L272, Rollup now uses dynamic import which is not defined in very old Node.

If we have two Rollup scripts, one for the old Node and one for new Node, we can make sure that this builds across all systems.

* use del instead of rimraf * Update package-lock.json

aminya · 2020-09-16T08:55:52Z

We can't install two rollups at the same time. Their bin file conflicts!

Using aliases does not help.

    "rollup-old": "npm:rollup@^1",
    "rollup": "^2.26.10",

@andywer I think you should decide that you want to be compatible with the old Rollup or the new one (which probably everyone uses).

aminya · 2020-09-16T09:03:21Z

We can use a custom script to call Rollup!

aminya · 2020-09-16T09:43:23Z

The old Node is pretty stupid 💢 It does not even parse catch {}.

andywer · 2020-09-16T16:39:48Z

@aminya Thanks so much for your efforts!

The old Node is pretty stupid 💢 It does not even parse catch {}.

Yeah, the blank catch {} syntax hasn't been around for that long. You can of course always write catch (error) {} and just not use the error, although you might have to tell the linter that this is fine in that case.

I am sorry that I can only contribute so little time at the moment, but I will try to help you as good as I can! That's obviously an important PR.

npm install -g npm-check-updates ncu -u -x mocha

This reverts commit 3b88852.

install old rollup in a script move rollup-script to scripts folder

npm sometimes fail to run prebuild before build. Using clean makes it explicit

aminya · 2020-10-27T10:03:43Z

This is ready to go 🚀

andywer · 2020-10-28T10:34:25Z

package.json

-    "prebuild": "rimraf dist/ dist-esm/",
-    "build": "run-p build:cjs build:es",
+    "clean": "rimraf dist/ dist-esm/",
+    "build": "npm run clean && npm run build:cjs && npm run build:es",


@aminya Any particular reason why you don't want to run it in parallel anymore? It will take much longer this way.

npm-run-all is unmaintained. It randomly fails on Windows. That should not be a problem though. For development, we can add a dev command which uses TypeScript's watch feature.

I added dev command in c09017e

Fair enough, but how about concurrently then?

We can try that.

aminya · 2020-10-28T11:13:38Z

Here is the CI run for the record: https://github.com/aminya/threads.js/actions/runs/333498686

Not sure why it is not shown here.

The ci timeouts!

andywer · 2020-10-28T13:24:17Z

@aminya Btw, I really appreciate the time and effort you put into this! Especially since I don't have much time right now. Great job 👍

aminya · 2020-11-01T01:06:57Z

You're welcome 👍🏻 😉

andywer · 2020-11-02T08:11:31Z

@aminya There is one thing about the GitHub actions workflow that we still need to fix: When the test fails with the retry action, we do not get to see the original error anymore: see here, for instance.

But I guess we should not auto-retry flaky tests in the first place. Let's check why they are flaky and fix them. It's also a bit strange, since they weren't flaky before – I could run them reliably on Travis CI and locally 🤔

aminya · 2020-11-02T08:40:29Z

@aminya There is one thing about the GitHub actions workflow that we still need to fix: When the test fails with the retry action, we do not get to see the original error anymore: see here, for instance.

But I guess we should not auto-retry flaky tests in the first place. Let's check why they are flaky and fix them. It's also a bit strange, since they weren't flaky before – I could run them reliably on Travis CI and locally 🤔

The tests of the package itself are fine. The test that bundles the code using Rollup sometimes timeouts! I tried to increase its timeout number in this commit, but that does not seem to make a difference 🤷‍♂️ Maybe I am doing it wrong.

This reverts commit fee4b35.

andywer · 2020-11-02T08:45:38Z

The test that bundles the code using Rollup sometimes timeouts!

Ohh, I see… Maybe we have a race condition in the rollup testing code. I can look into it later – some additional logging might give us a hint.

aminya · 2021-01-06T02:25:15Z

Bump

andywer · 2021-01-06T09:11:25Z

Thanks for the reminder! No time to look into it today, though, I fear… Maybe I get around looking into it until weekend.

aminya · 2021-01-09T04:04:13Z

Thanks. Hopefully, we can merge this on the weekend. This was ready and working. But some stuff has merged into master.

andywer · 2021-01-09T17:12:42Z

Merged 😉

andywer · 2021-01-09T17:19:04Z

@aminya Thanks again! Btw, do you need an update published urgently or were you just waiting for the dev dependencies to get fixed?

aminya · 2021-01-09T17:29:59Z

@andywer Thanks! This was blocking #290. Now I can merge that PR.

aminya mentioned this pull request Sep 7, 2020

Use del instead of rimraf andywer/puppet-run#39

Merged

aminya referenced this pull request in andywer/puppet-run Sep 16, 2020

Use del instead of rimraf (#39)

01404fb

* use del instead of rimraf * Update package-lock.json

aminya force-pushed the update-deps branch 4 times, most recently from 28267cb to ad2d8a8 Compare September 16, 2020 09:31

aminya changed the title ~~Update dependencies~~ Update dependencies + Fix old Rollup Sep 16, 2020

aminya force-pushed the update-deps branch from ad2d8a8 to 9c0cd31 Compare September 16, 2020 09:35

aminya changed the title ~~Update dependencies + Fix old Rollup~~ Update dependencies + test on Node>10 compatible dependencies Sep 16, 2020

Update dependencies

1c04be9

npm install -g npm-check-updates ncu -u -x mocha

aminya force-pushed the update-deps branch from 7b08f35 to 1107a4a Compare October 27, 2020 04:26

aminya marked this pull request as ready for review October 27, 2020 04:27

aminya added 10 commits October 26, 2020 23:40

import EventEmitter class instead of the namespace

a094ff5

ava: compileEnhancements is not enabled by default anymore

b45eeae

ava: fix throwsAsync API change

b226cb9

tslint: "array-type": false

b0826c0

use @rollup plugins

f683da4

use parcel to bundle instead of rollup

1e2d2da

Revert "use parcel to bundle instead of rollup"

1cd01ac

This reverts commit 3b88852.

detect the Rollup version based on Node version

f027f5b

add ts-ignore to rollup.config.ts

de9fe59

use a custom script to call Rollup

c878398

install old rollup in a script move rollup-script to scripts folder

rename prebuild to clean

a2f1e09

npm sometimes fail to run prebuild before build. Using clean makes it explicit

aminya force-pushed the update-deps branch from f167465 to a2f1e09 Compare October 27, 2020 09:42

increase timeout for Rollup test

9f78c24

aminya force-pushed the update-deps branch from de738d3 to 9f78c24 Compare October 27, 2020 09:52

andywer reviewed Oct 28, 2020

View reviewed changes

add dev command

c09017e

aminya force-pushed the update-deps branch from 3d5e7d1 to 0476be7 Compare October 28, 2020 11:01

ci: add fails-fast false to allow running all the jobs

6e08ec0

aminya force-pushed the update-deps branch from 0476be7 to 6e08ec0 Compare October 28, 2020 11:02

increase timeout time for bundling with rollup

31594e6

aminya added 2 commits October 28, 2020 06:21

await Rollup promises independently

c3cc39a

The ci timeouts!

increase timeout for webpack test

66b6437

aminya force-pushed the update-deps branch from 64124a6 to 66b6437 Compare October 28, 2020 11:21

retry flaky rollup/webpack tests

fee4b35

Revert "retry flaky rollup/webpack tests"

567ac17

This reverts commit fee4b35.

Merge branch 'master' into update-deps

30bb9e7

andywer merged commit 4d37802 into andywer:master Jan 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dependencies + test on Node>10 compatible dependencies #300

Update dependencies + test on Node>10 compatible dependencies #300

aminya commented Sep 7, 2020 •

edited

Loading

aminya commented Sep 7, 2020 •

edited

Loading

aminya commented Sep 13, 2020

andywer commented Sep 13, 2020

aminya commented Sep 16, 2020 •

edited

Loading

aminya commented Sep 16, 2020

aminya commented Sep 16, 2020

aminya commented Sep 16, 2020

andywer commented Sep 16, 2020

aminya commented Oct 27, 2020

andywer Oct 28, 2020

aminya Oct 28, 2020

aminya Oct 28, 2020

andywer Oct 28, 2020

aminya Nov 1, 2020

aminya commented Oct 28, 2020 •

edited

Loading

andywer commented Oct 28, 2020

aminya commented Nov 1, 2020

andywer commented Nov 2, 2020

aminya commented Nov 2, 2020

andywer commented Nov 2, 2020

aminya commented Jan 6, 2021

andywer commented Jan 6, 2021

aminya commented Jan 9, 2021

andywer commented Jan 9, 2021

andywer commented Jan 9, 2021

aminya commented Jan 9, 2021

Update dependencies + test on Node>10 compatible dependencies #300

Update dependencies + test on Node>10 compatible dependencies #300

Conversation

aminya commented Sep 7, 2020 • edited Loading

aminya commented Sep 7, 2020 • edited Loading

aminya commented Sep 13, 2020

andywer commented Sep 13, 2020

aminya commented Sep 16, 2020 • edited Loading

aminya commented Sep 16, 2020

aminya commented Sep 16, 2020

aminya commented Sep 16, 2020

andywer commented Sep 16, 2020

aminya commented Oct 27, 2020

andywer Oct 28, 2020

Choose a reason for hiding this comment

aminya Oct 28, 2020

Choose a reason for hiding this comment

aminya Oct 28, 2020

Choose a reason for hiding this comment

andywer Oct 28, 2020

Choose a reason for hiding this comment

aminya Nov 1, 2020

Choose a reason for hiding this comment

aminya commented Oct 28, 2020 • edited Loading

andywer commented Oct 28, 2020

aminya commented Nov 1, 2020

andywer commented Nov 2, 2020

aminya commented Nov 2, 2020

andywer commented Nov 2, 2020

aminya commented Jan 6, 2021

andywer commented Jan 6, 2021

aminya commented Jan 9, 2021

andywer commented Jan 9, 2021

andywer commented Jan 9, 2021

aminya commented Jan 9, 2021

aminya commented Sep 7, 2020 •

edited

Loading

aminya commented Sep 7, 2020 •

edited

Loading

aminya commented Sep 16, 2020 •

edited

Loading

aminya commented Oct 28, 2020 •

edited

Loading