-
Notifications
You must be signed in to change notification settings - Fork 41
chore(demo app): cleanup appearance and other code #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
michael-small
wants to merge
14
commits into
angular-architects:main
Choose a base branch
from
michael-small:chore-app-qol
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
chore(demo app): cleanup appearance and other code #211
michael-small
wants to merge
14
commits into
angular-architects:main
from
michael-small:chore-app-qol
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes overall: - Material fields + buttons etc - Page titles - Some field ordering in classes
Below |
Good catch, I have been focused on it being a bit broken in a more traditional desktop size/ratio but had not considered smaller sizes. Will check that out once I get some stuff at the size I was working with on par with before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo application is my go-to way to make changes to features, before formally running tests and whatnot. When running it recently, I found and fixed the following:
withReset
page, as I was experimenting with changes in that featurewithReset
cleanup before marking this for review