Skip to content

fix: fix broken meta tag for twitter image #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LoganDupont
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Due to a previous PR #389 I broke the meta-tag for twitter:image and replaced it with x:image which doesn't exist

Issue Number: N/A

What is the new behavior?

I reverted the changes that broke the meta-tag for twitter:image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

/

Copy link

netlify bot commented Apr 13, 2025

Deploy Preview for angular-hub ready!

Name Link
🔨 Latest commit 6c6647c
🔍 Latest deploy log https://app.netlify.com/sites/angular-hub/deploys/67fc4ca57bfebc0007241ee1
😎 Deploy Preview https://deploy-preview-390--angular-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LoganDupont LoganDupont mentioned this pull request Apr 13, 2025
13 tasks
@geromegrignon geromegrignon merged commit ff1a921 into angular-sanctuary:main Apr 14, 2025
5 checks passed
@geromegrignon
Copy link
Contributor

thanks for the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants