-
Notifications
You must be signed in to change notification settings - Fork 11.9k
feat(@schematics/angular): use signal in app component #29109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/schematics/angular/application/files/module-files/src/app/app.component.ts.template
Outdated
Show resolved
Hide resolved
db677fc
to
f849d0c
Compare
This updates the generated `App` component to use a signal for the `title` field.
f849d0c
to
7d34878
Compare
@alan-agius4 @dgp1130 PR is ready for review with your feedback |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for updating.
@alan-agius4, is there anything else we need to update, or should this be sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the contribution, apologies for the long delay on this! |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Now that signals are recommended, this updates the generated
AppComponent
to use a signal for thetitle
field.Does this PR introduce a breaking change?
Other information