Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): add how-to for Font Awesome inclusion #3898

Closed
wants to merge 1 commit into from

Conversation

jeremymwells
Copy link
Contributor

applies to #2711

@ladyleet
Copy link

ladyleet commented Jan 7, 2017

@jeremymwells love that! i just included font awesome in my angular cli app. boom diggity! uses angular material 2 and the new flex box release. https://github.com/ladyleet/ladyleet-material2

@jeremymwells
Copy link
Contributor Author

@ladyleet - NICE! Atta gurl! Are you referring to my other PR?

@baruchvlz
Copy link
Contributor

baruchvlz commented Jan 8, 2017

@jeremymwells Another way to add it is to just add it to the angular-cli.json file

"styles": [
    "styles.css",
    "../node_modules/font-awesome/css/font-awesome.css"
]

@ladyleet Why use FA instead of MD icons in a material2 project?

@jeremymwells
Copy link
Contributor Author

@baruchvlz - very true. I had actually considered that. My thinking was that Font Awesome is an app module dependency, not necessarily an Application-level dependency, and it should be imported in app.component.css, but I wasn't sure if that change belonged in this PR, which is why I put the import in styles.css.


Install the `font-awesome` library and add the dependency to package.json...
```bash
npm install --save-dev font-awesome
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be --save instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


Run `ng serve` to run your application in develop mode, and navigate to `http://localhost:4200`.

To verify angular material has been set up correctly, change `src/app/app.component.html` to the following...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font Awesome instead of angular material?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jeremymwells jeremymwells force-pushed the docs-font-awesome branch 4 times, most recently from be1c4e9 to 4db0106 Compare January 10, 2017 00:34
@Brocco Brocco mentioned this pull request Jan 17, 2017
38 tasks
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants